Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2436)

Unified Diff: chrome/browser/resources/md_bookmarks/item.js

Issue 2704983002: MD Bookmarks: Proof-of-concept reimplementation of data storage/binding layer (Closed)
Patch Set: Add doc comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/md_bookmarks/item.html ('k') | chrome/browser/resources/md_bookmarks/list.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_bookmarks/item.js
diff --git a/chrome/browser/resources/md_bookmarks/item.js b/chrome/browser/resources/md_bookmarks/item.js
index b75eb60de66bcab9440193406fa7a755ff258a94..cfea77e7ea0630d546b5795c2d44323518f0ab42 100644
--- a/chrome/browser/resources/md_bookmarks/item.js
+++ b/chrome/browser/resources/md_bookmarks/item.js
@@ -5,13 +5,22 @@
Polymer({
is: 'bookmarks-item',
+ behaviors: [
+ bookmarks.StoreClient,
+ ],
+
properties: {
- /** @type {BookmarkTreeNode} */
+ /** @type {BookmarkNode} */
item: {
type: Object,
observer: 'onItemChanged_',
},
+ itemId: {
+ type: String,
+ observer: 'updateFromStore',
+ },
+
isFolder_: Boolean,
isSelectedItem: {
@@ -29,6 +38,17 @@ Polymer({
'dblclick': 'onDblClick_',
},
+ attached: function() {
+ this.observe('item', function(store) {
+ return store.nodes[this.itemId];
+ }.bind(this));
+ this.observe('isSelectedItem', function(store) {
+ return store.selection.items[this.itemId];
+ }.bind(this));
+
+ this.updateFromStore();
+ },
+
/**
* @param {Event} e
* @private
@@ -51,11 +71,8 @@ Polymer({
* @private
*/
onClick_: function(e) {
- this.fire('select-item', {
- item: this.item,
- range: e.shiftKey,
- add: e.ctrlKey,
- });
+ this.dispatch(bookmarks.actions.selectItem(
+ this.itemId, e.ctrlKey, e.shiftKey, this.getState()));
},
/**
@@ -64,7 +81,7 @@ Polymer({
*/
onDblClick_: function(e) {
if (!this.item.url)
- this.fire('selected-folder-changed', this.item.id);
+ this.dispatch(bookmarks.actions.selectFolder(this.item.id));
else
chrome.tabs.create({url: this.item.url});
},
« no previous file with comments | « chrome/browser/resources/md_bookmarks/item.html ('k') | chrome/browser/resources/md_bookmarks/list.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698