Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2704933004: Revert of Fix stack walking to notice if the frame is obviously not valid. (Closed)

Created:
3 years, 10 months ago by vabr (Chromium)
Modified:
3 years, 10 months ago
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix stack walking to notice if the frame is obviously not valid. (patchset #2 id:20001 of https://codereview.chromium.org/2692123005/ ) Reason for revert: This likely caused a consistent breakage on CrOS ASAN/LSAN bot: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/19604 More info on https://crbug.com/677302#c16 Original issue's description: > Fix stack walking to notice if the frame is obviously not valid. > > If the PC is too small, the frame can't be valid. > > BUG=677302 > > Review-Url: https://codereview.chromium.org/2692123005 > Cr-Commit-Position: refs/heads/master@{#451355} > Committed: https://chromium.googlesource.com/chromium/src/+/f51b7d1a5db6ae289736b84622494086c54cd49a TBR=mark@chromium.org,wez@chromium.org,erikchen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=677302 Review-Url: https://codereview.chromium.org/2704933004 Cr-Commit-Position: refs/heads/master@{#451774} Committed: https://chromium.googlesource.com/chromium/src/+/27f8b7ea6bbee0b512ce820842ebe8bba019b050

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M base/debug/stack_trace.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
vabr (Chromium)
Created Revert of Fix stack walking to notice if the frame is obviously not valid.
3 years, 10 months ago (2017-02-20 13:21:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704933004/1
3 years, 10 months ago (2017-02-20 13:21:18 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/122634)
3 years, 10 months ago (2017-02-20 14:34:24 UTC) #5
fdoray
On 2017/02/20 14:34:24, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 10 months ago (2017-02-21 14:30:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704933004/1
3 years, 10 months ago (2017-02-21 14:30:41 UTC) #9
vabr (Chromium)
On 2017/02/21 14:30:41, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 10 months ago (2017-02-21 14:39:08 UTC) #10
fdoray
On 2017/02/21 14:39:08, vabr (Chromium) wrote: > On 2017/02/21 14:30:41, commit-bot: I haz the power ...
3 years, 10 months ago (2017-02-21 14:58:03 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/27f8b7ea6bbee0b512ce820842ebe8bba019b050
3 years, 10 months ago (2017-02-21 16:29:31 UTC) #14
vabr (Chromium)
3 years, 10 months ago (2017-02-21 20:34:00 UTC) #15
Message was sent while issue was closed.
On 2017/02/21 14:58:03, fdoray wrote:
> On 2017/02/21 14:39:08, vabr (Chromium) wrote:
> > On 2017/02/21 14:30:41, commit-bot: I haz the power wrote:
> > > CQ is trying da patch. Follow status at
> > >  
> > >
> >
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> > 
> > If this fails again on android_n5x_swarming_rel, then please do not force it
> > through. I left a message in https://crbug.com/677302#c18 hoping that the
> owners
> > would pick this up.
> > 
> > Cheers,
> > Vaclav
> 
> I uploaded a CL to fix the unrelated gl_unittests failure
> https://codereview.chromium.org/2708923003. I'll try to reland this
afterwards.

Thanks!
Vaclav

Powered by Google App Engine
This is Rietveld 408576698