Use base::test::ScopedAsyncTaskScheduler in GLImageTest.

Use base::test::ScopedAsyncTaskScheduler in GLImageTest.

GLImageTest registers a TaskScheduler by calling
base::test::CreateAndSetSimpleTaskScheduler, but never unregisters
it. The second GLImageTest running in fails because there is
already a registered TaskScheduler.

This CL replaces the call to base::test::CreateAndSetSimpleTaskScheduler
with a base::test::ScopedAsyncTaskScheduler member which takes care of
registering a TaskScheduler at the beginning of the test and
unregistering it at the end of the test.

BUG=693203
Review-Url: https://codereview.chromium.org/2708923003
Cr-Commit-Position: refs/heads/master@{#451842}
Committed: https://chromium.googlesource.com/chromium/src/+/8a9cc7e7dc99a62392c3a8fd02ac4c3a56415240

[fdoray, 2017-02-21 14:55:43]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 14:56:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 15:12:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 15:12:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fdoray, 2017-02-21 15:24:40]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 15:25:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 15:29:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 15:29:27]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[fdoray, 2017-02-21 15:49:27]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 15:49:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 15:54:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 15:54:15]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[fdoray, 2017-02-21 15:58:26]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 15:58:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 16:02:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 16:02:52]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[fdoray, 2017-02-21 16:28:46]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 16:29:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-02-21 18:13:58]

fdoray@chromium.org changed reviewers:
+ reveman@chromium.org

[fdoray, 2017-02-21 18:13:59]

PTAL

[Daniele Castagna, 2017-02-21 18:42:39]

dcastagna@chromium.org changed reviewers:
+ dcastagna@chromium.org

[Daniele Castagna, 2017-02-21 18:42:40]

LGTM, thanks!

[commit-bot: I haz the power, 2017-02-21 18:45:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 18:46:00]

Dry run: This issue passed the CQ dry run.

[Ken Russell (switch to Gerrit), 2017-02-21 18:50:13]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2017-02-21 18:50:14]

Thanks for the fix! LGTM too.

[fdoray, 2017-02-21 19:03:15]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-02-21 19:04:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 21:06:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 21:06:49]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[Ken Russell (switch to Gerrit), 2017-02-21 21:14:44]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2017-02-21 21:16:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 21:53:22]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487711684618450,
"parent_rev": "310a283e2982013c42652daa4af5c2ad621a5013", "commit_rev":
"8a9cc7e7dc99a62392c3a8fd02ac4c3a56415240"}

[commit-bot: I haz the power, 2017-02-21 21:53:58]

Description was changed from

==========
Use base::test::ScopedAsyncTaskScheduler in GLImageTest.

GLImageTest registers a TaskScheduler by calling
base::test::CreateAndSetSimpleTaskScheduler, but never unregisters
it. The second GLImageTest running in fails because there is
already a registered TaskScheduler.

This CL replaces the call to base::test::CreateAndSetSimpleTaskScheduler
with a base::test::ScopedAsyncTaskScheduler member which takes care of
registering a TaskScheduler at the beginning of the test and
unregistering it at the end of the test.

BUG=693203
==========

to

==========
Use base::test::ScopedAsyncTaskScheduler in GLImageTest.

GLImageTest registers a TaskScheduler by calling
base::test::CreateAndSetSimpleTaskScheduler, but never unregisters
it. The second GLImageTest running in fails because there is
already a registered TaskScheduler.

This CL replaces the call to base::test::CreateAndSetSimpleTaskScheduler
with a base::test::ScopedAsyncTaskScheduler member which takes care of
registering a TaskScheduler at the beginning of the test and
unregistering it at the end of the test.

BUG=693203

Review-Url: https://codereview.chromium.org/2708923003
Cr-Commit-Position: refs/heads/master@{#451842}
Committed:
https://chromium.googlesource.com/chromium/src/+/8a9cc7e7dc99a62392c3a8fd02ac...
==========

[commit-bot: I haz the power, 2017-02-21 21:53:59]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/8a9cc7e7dc99a62392c3a8fd02ac...