Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1253)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2704673003: Check same-thread Persistent<> read access. (Closed)

Created:
3 years, 10 months ago by sof
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), haraken, blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check same-thread Persistent<> read access. R= BUG=

Patch Set 1 #

Patch Set 2 : introduce crossThreadGet() #

Patch Set 3 : add a pair of crossThreadGet() uses (ThreadedMessagingProxyBase) #

Patch Set 4 : cross-thread clean access of ParentFrameTaskRunners #

Patch Set 5 : more cross-thread access fixes #

Patch Set 6 : more cross-threads fixups #

Patch Set 7 : make ParentFrameTaskRunners a ctp #

Patch Set 8 : fix WebScrollbarImpl cross-ref #

Patch Set 9 : tail end.. #

Patch Set 10 : long tail end.. #

Patch Set 11 : long tail end.. #

Patch Set 12 : CTPs needed for audio thread accesses #

Patch Set 13 : final set.. #

Patch Set 14 : compile fixes (ASan) #

Patch Set 15 : compile fixes (ASan) #

Patch Set 16 : rebased and simplified upto r451580 #

Patch Set 17 : decided against crossThreadGet() #

Patch Set 18 : final comments #

Patch Set 19 : final comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -68 lines) Patch
M third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/DummyPageHolder.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 4 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ConvolverNode.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +8 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 7 chunks +9 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OscillatorNode.h View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/PannerNode.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebScrollbarImpl.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/CompositorMutatorClient.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Persistent.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +14 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 62 (62 generated)
sof
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
3 years, 10 months ago (2017-02-17 21:36:01 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704673003/1
3 years, 10 months ago (2017-02-17 21:36:57 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-17 22:43:04 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/312322)
3 years, 10 months ago (2017-02-17 22:43:05 UTC) #4
sof
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
3 years, 10 months ago (2017-02-18 06:22:18 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704673003/20001
3 years, 10 months ago (2017-02-18 06:22:43 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-18 07:16:04 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/313880)
3 years, 10 months ago (2017-02-18 07:16:05 UTC) #8
sof
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
3 years, 10 months ago (2017-02-18 07:43:15 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704673003/40001
3 years, 10 months ago (2017-02-18 07:43:34 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-18 08:16:55 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/214527)
3 years, 10 months ago (2017-02-18 08:16:56 UTC) #12
sof
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
3 years, 10 months ago (2017-02-18 08:20:22 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704673003/60001
3 years, 10 months ago (2017-02-18 08:20:34 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-18 08:57:25 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/313894)
3 years, 10 months ago (2017-02-18 08:57:26 UTC) #16
sof
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
3 years, 10 months ago (2017-02-18 11:34:51 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704673003/30003
3 years, 10 months ago (2017-02-18 11:35:07 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-18 12:07:35 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/313913)
3 years, 10 months ago (2017-02-18 12:07:36 UTC) #20
sof
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
3 years, 10 months ago (2017-02-18 12:43:26 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704673003/90001
3 years, 10 months ago (2017-02-18 12:43:30 UTC) #22
sof
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
3 years, 10 months ago (2017-02-18 13:15:43 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704673003/110001
3 years, 10 months ago (2017-02-18 13:15:56 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-18 13:46:47 UTC) #25
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/313922)
3 years, 10 months ago (2017-02-18 13:46:48 UTC) #26
sof
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
3 years, 10 months ago (2017-02-18 14:13:00 UTC) #27
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704673003/130001
3 years, 10 months ago (2017-02-18 14:13:18 UTC) #28
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-18 14:37:40 UTC) #29
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/312624)
3 years, 10 months ago (2017-02-18 14:37:41 UTC) #30
sof
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
3 years, 10 months ago (2017-02-18 15:21:48 UTC) #31
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704673003/150001
3 years, 10 months ago (2017-02-18 15:21:57 UTC) #32
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-18 15:45:49 UTC) #33
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/324912)
3 years, 10 months ago (2017-02-18 15:45:50 UTC) #34
sof
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
3 years, 10 months ago (2017-02-18 16:18:08 UTC) #35
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704673003/100012
3 years, 10 months ago (2017-02-18 16:18:21 UTC) #36
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-18 16:42:46 UTC) #37
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/312640)
3 years, 10 months ago (2017-02-18 16:42:47 UTC) #38
sof
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
3 years, 10 months ago (2017-02-18 17:37:32 UTC) #39
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704673003/200001
3 years, 10 months ago (2017-02-18 17:37:45 UTC) #40
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-18 18:08:22 UTC) #41
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/313959)
3 years, 10 months ago (2017-02-18 18:08:23 UTC) #42
sof
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
3 years, 10 months ago (2017-02-18 20:42:07 UTC) #43
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704673003/220001
3 years, 10 months ago (2017-02-18 20:42:19 UTC) #44
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-18 21:14:32 UTC) #45
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/313986)
3 years, 10 months ago (2017-02-18 21:14:33 UTC) #46
sof
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
3 years, 10 months ago (2017-02-19 07:47:54 UTC) #47
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704673003/240001
3 years, 10 months ago (2017-02-19 07:48:08 UTC) #48
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-19 08:31:22 UTC) #49
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/314042)
3 years, 10 months ago (2017-02-19 08:31:23 UTC) #50
sof
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
3 years, 10 months ago (2017-02-19 14:38:55 UTC) #51
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704673003/260001
3 years, 10 months ago (2017-02-19 14:39:07 UTC) #52
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-19 16:06:30 UTC) #53
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/325032)
3 years, 10 months ago (2017-02-19 16:06:31 UTC) #54
sof
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
3 years, 10 months ago (2017-02-20 08:47:15 UTC) #55
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704673003/280001
3 years, 10 months ago (2017-02-20 08:47:24 UTC) #56
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-20 10:52:04 UTC) #57
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 10 months ago (2017-02-20 10:52:06 UTC) #58
sof
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
3 years, 10 months ago (2017-02-20 13:04:36 UTC) #59
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704673003/330001
3 years, 10 months ago (2017-02-20 13:04:59 UTC) #60
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-20 15:19:40 UTC) #61
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 15:19:42 UTC) #62 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698