third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.h - Issue 2704673003: Check same-thread Persistent<> read access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.h

Issue 2704673003: Check same-thread Persistent<> read access. (Closed)

Patch Set: final comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/ConvolverNode.h ('k') | third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.h b/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.h

index 1a855674e3858ac78d6fbcf21f5514fbcfbc8e8a..40330eac4058a90f0b486c835c20c92722a9593e 100644

--- a/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.h

@@ -45,7 +45,7 @@ class MediaElementAudioSourceHandler final : public AudioHandler {

HTMLMediaElement&);

~MediaElementAudioSourceHandler() override;

- HTMLMediaElement* mediaElement() { return m_mediaElement.get(); }

+ HTMLMediaElement* mediaElement() const;

// AudioHandler

void dispose() override;

@@ -76,7 +76,9 @@ class MediaElementAudioSourceHandler final : public AudioHandler {

// This Persistent doesn't make a reference cycle. The reference from

// HTMLMediaElement to AudioSourceProvideClient, which

// MediaElementAudioSourceNode implements, is weak.

- Persistent<HTMLMediaElement> m_mediaElement;

+ //

+ // It is accessed by both audio and main thread.

+ CrossThreadPersistent<HTMLMediaElement> m_mediaElement;

Mutex m_processLock;

unsigned m_sourceNumberOfChannels;