third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h - Issue 2704673003: Check same-thread Persistent<> read access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h

Issue 2704673003: Check same-thread Persistent<> read access. (Closed)

Patch Set: final comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/OscillatorNode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h b/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h

index d8073ce6820eb03df3cf11ed57c38d7ba89f70cf..c18c39fe24f93622abf5ce6102ceb8d97d95872f 100644

--- a/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h

@@ -106,8 +106,8 @@ class OfflineAudioDestinationHandler final : public AudioDestinationHandler {

// This AudioHandler renders into this AudioBuffer.

// This Persistent doesn't make a reference cycle including the owner

- // OfflineAudioDestinationNode.

- Persistent<AudioBuffer> m_renderTarget;

+ // OfflineAudioDestinationNode. It is accessed by both audio and main thread.

+ CrossThreadPersistent<AudioBuffer> m_renderTarget;

// Temporary AudioBus for each render quantum.

RefPtr<AudioBus> m_renderBus;