VM: [Kernel] Ensure we record [FieldLoadInstr]s in the ParsedFunction when using field guards

VM: [Kernel] Ensure we record [FieldLoadInstr]s in the ParsedFunction when using field guards

R=vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/20130a2d43a9a95d64c4fcfae7166ad1e9e21a60

[kustermann, 2017-02-17 09:59:11]

kustermann@google.com changed reviewers:
+ vegorov@google.com

[kustermann, 2017-02-17 09:59:12]

https://codereview.chromium.org/2704623003/diff/1/runtime/vm/kernel_to_il.cc
File runtime/vm/kernel_to_il.cc (right):

https://codereview.chromium.org/2704623003/diff/1/runtime/vm/kernel_to_il.cc#...
runtime/vm/kernel_to_il.cc:2479: Fragment
FlowGraphBuilder::LoadNativeField(MethodRecognizer::Kind kind,
For LoadFields for context and native fields we don't need it, right?

[Vyacheslav Egorov (Google), 2017-02-17 10:24:32]

lgtm

https://codereview.chromium.org/2704623003/diff/1/runtime/vm/kernel_to_il.cc
File runtime/vm/kernel_to_il.cc (right):

https://codereview.chromium.org/2704623003/diff/1/runtime/vm/kernel_to_il.cc#...
runtime/vm/kernel_to_il.cc:2458: if (field.guarded_cid() != kIllegalCid) {
I wonder if we should make a factory function on LoadFieldInstr that creates
load fields and makes sure to add it to the list of guarded fields?

https://codereview.chromium.org/2704623003/diff/1/runtime/vm/kernel_to_il.cc#...
runtime/vm/kernel_to_il.cc:2479: Fragment
FlowGraphBuilder::LoadNativeField(MethodRecognizer::Kind kind,
On 2017/02/17 09:59:12, kustermann wrote:
> For LoadFields for context and native fields we don't need it, right?

No.

[kustermann, 2017-02-17 10:56:04]

Patchset #2 (id:20001) has been deleted

[kustermann, 2017-02-17 10:58:05]

ptal

https://codereview.chromium.org/2704623003/diff/1/runtime/vm/kernel_to_il.cc
File runtime/vm/kernel_to_il.cc (right):

https://codereview.chromium.org/2704623003/diff/1/runtime/vm/kernel_to_il.cc#...
runtime/vm/kernel_to_il.cc:2458: if (field.guarded_cid() != kIllegalCid) {
On 2017/02/17 10:24:31, Vyacheslav Egorov (Google) wrote:
> I wonder if we should make a factory function on LoadFieldInstr that creates
> load fields and makes sure to add it to the list of guarded fields?

We have a number of places with this code, so I'll go ahead and do that.

[kustermann, 2017-02-17 11:01:05]

Patchset #2 (id:40001) has been deleted

[Vyacheslav Egorov (Google), 2017-02-17 11:39:50]

lgtm

[kustermann, 2017-02-17 12:10:27]

Description was changed from

==========
VM: [Kernel] Ensure we record [FieldLoadInstr]s in the ParsedFunction when using
field guards
==========

to

==========
VM: [Kernel] Ensure we record [FieldLoadInstr]s in the ParsedFunction when using
field guards

R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/20130a2d43a9a95d64c4fcfae7166ad1e9e21a60
==========

[kustermann, 2017-02-17 12:10:29]

Committed patchset #2 (id:60001) manually as
20130a2d43a9a95d64c4fcfae7166ad1e9e21a60 (presubmit successful).