Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: runtime/vm/kernel_to_il.cc

Issue 2704623003: VM: [Kernel] Ensure we record [FieldLoadInstr]s in the ParsedFunction when using field guards (Closed)
Patch Set: Moved the AddToGuardedFields call to the LoadFieldInstr constructor Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/jit_optimizer.cc ('k') | runtime/vm/redundancy_elimination.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include <map> 5 #include <map>
6 #include <set> 6 #include <set>
7 #include <string> 7 #include <string>
8 8
9 #include "vm/kernel_to_il.h" 9 #include "vm/kernel_to_il.h"
10 10
(...skipping 2434 matching lines...) Expand 10 before | Expand all | Expand 10 after
2445 field.IsOriginal()) { 2445 field.IsOriginal()) {
2446 return dart::Field::ZoneHandle(zone, field.CloneFromOriginal()); 2446 return dart::Field::ZoneHandle(zone, field.CloneFromOriginal());
2447 } else { 2447 } else {
2448 ASSERT(field.IsZoneHandle()); 2448 ASSERT(field.IsZoneHandle());
2449 return field; 2449 return field;
2450 } 2450 }
2451 } 2451 }
2452 2452
2453 2453
2454 Fragment FlowGraphBuilder::LoadField(const dart::Field& field) { 2454 Fragment FlowGraphBuilder::LoadField(const dart::Field& field) {
2455 LoadFieldInstr* load = new (Z) LoadFieldInstr( 2455 LoadFieldInstr* load =
2456 Pop(), &MayCloneField(Z, field), 2456 new (Z) LoadFieldInstr(Pop(), &MayCloneField(Z, field),
2457 AbstractType::ZoneHandle(Z, field.type()), TokenPosition::kNoSource); 2457 AbstractType::ZoneHandle(Z, field.type()),
2458 TokenPosition::kNoSource, parsed_function_);
2458 Push(load); 2459 Push(load);
2459 return Fragment(load); 2460 return Fragment(load);
2460 } 2461 }
2461 2462
2462 2463
2463 Fragment FlowGraphBuilder::LoadField(intptr_t offset, intptr_t class_id) { 2464 Fragment FlowGraphBuilder::LoadField(intptr_t offset, intptr_t class_id) {
2464 LoadFieldInstr* load = new (Z) LoadFieldInstr( 2465 LoadFieldInstr* load = new (Z) LoadFieldInstr(
2465 Pop(), offset, AbstractType::ZoneHandle(Z), TokenPosition::kNoSource); 2466 Pop(), offset, AbstractType::ZoneHandle(Z), TokenPosition::kNoSource);
2466 load->set_result_cid(class_id); 2467 load->set_result_cid(class_id);
2467 Push(load); 2468 Push(load);
(...skipping 3812 matching lines...) Expand 10 before | Expand all | Expand 10 after
6280 thread->clear_sticky_error(); 6281 thread->clear_sticky_error();
6281 return error.raw(); 6282 return error.raw();
6282 } 6283 }
6283 } 6284 }
6284 6285
6285 6286
6286 } // namespace kernel 6287 } // namespace kernel
6287 } // namespace dart 6288 } // namespace dart
6288 6289
6289 #endif // !defined(DART_PRECOMPILED_RUNTIME) 6290 #endif // !defined(DART_PRECOMPILED_RUNTIME)
OLDNEW
« no previous file with comments | « runtime/vm/jit_optimizer.cc ('k') | runtime/vm/redundancy_elimination.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698