Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 2704623003: VM: [Kernel] Ensure we record [FieldLoadInstr]s in the ParsedFunction when using field guards (Closed)
Patch Set: Moved the AddToGuardedFields call to the LoadFieldInstr constructor Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/aot_optimizer.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc
index a6547d17415947ede1c55dc2df63c0765d8b60ae..cd7733be013d1ecef60e3a711f88435d7a71d74e 100644
--- a/runtime/vm/flow_graph_builder.cc
+++ b/runtime/vm/flow_graph_builder.cc
@@ -3414,16 +3414,10 @@ void EffectGraphVisitor::VisitLoadInstanceFieldNode(
ValueGraphVisitor for_instance(owner());
node->instance()->Visit(&for_instance);
Append(for_instance);
- LoadFieldInstr* load = new (Z) LoadFieldInstr(
- for_instance.value(), &node->field(),
- AbstractType::ZoneHandle(Z, node->field().type()), node->token_pos());
- if (node->field().guarded_cid() != kIllegalCid) {
- if (!node->field().is_nullable() ||
- (node->field().guarded_cid() == kNullCid)) {
- load->set_result_cid(node->field().guarded_cid());
- }
- owner()->parsed_function().AddToGuardedFields(&node->field());
- }
+ LoadFieldInstr* load =
+ new (Z) LoadFieldInstr(for_instance.value(), &node->field(),
+ AbstractType::ZoneHandle(Z, node->field().type()),
+ node->token_pos(), &owner()->parsed_function());
ReturnDefinition(load);
}
« no previous file with comments | « runtime/vm/aot_optimizer.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698