Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2704613002:
[InputEvent] Make typing and IME related input types non-cancelable (Closed)
|
Created:
3 years, 10 months ago by chongz Modified:
3 years, 10 months ago Reviewers:
yosin_UTC9 CC:
blink-reviews, chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[InputEvent] Make typing and IME related input types non-cancelable
Please refer to bug for spec and detailed proposal.
BUG=693242
Review-Url: https://codereview.chromium.org/2704613002
Cr-Commit-Position: refs/heads/master@{#452303}
Committed: https://chromium.googlesource.com/chromium/src/+/c92612b03e612a51245e5bd02de19051284150b5
Patch Set 1 #Patch Set 2 : Add cancelability tests #
Total comments: 4
Patch Set 3 : yosin's review: Replace == with === #
Messages
Total messages: 24 (17 generated)
The CQ bit was checked by chongz@chromium.org to run a CQ dry run
Description was changed from ========== Make typing and IME related input types non-cancelable BUG= ========== to ========== [InputEvent] Make typing and IME related input types non-cancelable Please refer to bug for spec and detailed proposal. BUG=693242 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
chongz@chromium.org changed reviewers: + yosin@chromium.org
yosin@ PTAL, thanks!
It seems we have not had test to verify cancelability. Since, this patch doesn't contain test update. Let's have a test for this. Should we have tests in WPT? Since this change is for spec conformance.
The CQ bit was checked by chongz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
yosin@ I've added cancelability test and added 'insertReplacementText' to non-cancelable category according to the latest discussion. PTAL again, thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
lgtm w/ small nits https://codereview.chromium.org/2704613002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-cancelable.html (right): https://codereview.chromium.org/2704613002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-cancelable.html:57: assert_equals(kNoncancelableInputTypes.indexOf(event.inputType) == -1, event.cancelable); nit: s/==/===/ https://codereview.chromium.org/2704613002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-cancelable.html:82: const isMacOS = navigator.platform.indexOf('Mac') == 0; nit: s/==/===/
The CQ bit was checked by chongz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by chongz@chromium.org
https://codereview.chromium.org/2704613002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-cancelable.html (right): https://codereview.chromium.org/2704613002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-cancelable.html:57: assert_equals(kNoncancelableInputTypes.indexOf(event.inputType) == -1, event.cancelable); On 2017/02/22 06:48:55, yosin_UTC9 wrote: > nit: s/==/===/ Done. https://codereview.chromium.org/2704613002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-cancelable.html:82: const isMacOS = navigator.platform.indexOf('Mac') == 0; On 2017/02/22 06:48:55, yosin_UTC9 wrote: > nit: s/==/===/ Done.
The CQ bit was checked by chongz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org Link to the patchset: https://codereview.chromium.org/2704613002/#ps40001 (title: "yosin's review: Replace == with ===")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487801375350690,
"parent_rev": "f512fd9e5fbf57c966b2d59c59e738112a5cb4e5", "commit_rev":
"c92612b03e612a51245e5bd02de19051284150b5"}
Message was sent while issue was closed.
Description was changed from ========== [InputEvent] Make typing and IME related input types non-cancelable Please refer to bug for spec and detailed proposal. BUG=693242 ========== to ========== [InputEvent] Make typing and IME related input types non-cancelable Please refer to bug for spec and detailed proposal. BUG=693242 Review-Url: https://codereview.chromium.org/2704613002 Cr-Commit-Position: refs/heads/master@{#452303} Committed: https://chromium.googlesource.com/chromium/src/+/c92612b03e612a51245e5bd02de1... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/c92612b03e612a51245e5bd02de1... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
