[InputEvent] Make typing and IME related input types non-cancelable

third_party/WebKit/Source/core/editing/EditingUtilities.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 61 matching lines @@
 
 std::ostream& operator<<(std::ostream& os, PositionMoveType type) {
   static const char* const texts[] = {"CodeUnit", "BackwardDeletion",
                                       "GraphemeCluster"};
   const auto& it = std::begin(texts) + static_cast<size_t>(type);
   DCHECK_GE(it, std::begin(texts)) << "Unknown PositionMoveType value";
   DCHECK_LT(it, std::end(texts)) << "Unknown PositionMoveType value";
   return os << *it;
 }
 
+InputEvent::EventCancelable inputTypeIsCancelable(
+    InputEvent::InputType inputType) {
+  using InputType = InputEvent::InputType;
+  switch (inputType) {
+    case InputType::InsertText:
+    case InputType::InsertLineBreak:
+    case InputType::InsertParagraph:
+    case InputType::InsertCompositionText:
+    case InputType::InsertReplacementText:
+    case InputType::DeleteWordBackward:
+    case InputType::DeleteWordForward:
+    case InputType::DeleteLineBackward:
+    case InputType::DeleteLineForward:
+    case InputType::DeleteContentBackward:
+    case InputType::DeleteContentForward:
+      return InputEvent::EventCancelable::NotCancelable;
+    default:
+      return InputEvent::EventCancelable::IsCancelable;
+  }
+}
+
 }  // namespace
 
 static bool needsLayoutTreeUpdate(const Node& node) {
   const Document& document = node.document();
   if (document.needsLayoutTreeUpdate())
     return true;
   // TODO(yosin): We should make |document::needsLayoutTreeUpdate()| to
   // check |LayoutView::needsLayout()|.
   return document.view() && document.view()->needsLayout();
 }
@@ skipping 1961 matching lines @@
 }
 
 DispatchEventResult dispatchBeforeInputInsertText(Node* target,
                                                   const String& data) {
   if (!RuntimeEnabledFeatures::inputEventEnabled())
     return DispatchEventResult::NotCanceled;
   if (!target)
     return DispatchEventResult::NotCanceled;
   // TODO(chongz): Pass appropriate |ranges| after it's defined on spec.
   // http://w3c.github.io/editing/input-events.html#dom-inputevent-inputtype
-  InputEvent* beforeInputEvent =
-      InputEvent::createBeforeInput(InputEvent::InputType::InsertText, data,
-                                    InputEvent::EventCancelable::IsCancelable,
-                                    InputEvent::EventIsComposing::NotComposing,
-                                    targetRangesForInputEvent(*target));
+  InputEvent* beforeInputEvent = InputEvent::createBeforeInput(
+      InputEvent::InputType::InsertText, data,
+      inputTypeIsCancelable(InputEvent::InputType::InsertText),
+      InputEvent::EventIsComposing::NotComposing,
+      targetRangesForInputEvent(*target));
   return target->dispatchEvent(beforeInputEvent);
 }
 
 DispatchEventResult dispatchBeforeInputEditorCommand(
     Node* target,
     InputEvent::InputType inputType,
     const RangeVector* ranges) {
   if (!RuntimeEnabledFeatures::inputEventEnabled())
     return DispatchEventResult::NotCanceled;
   if (!target)
     return DispatchEventResult::NotCanceled;
   InputEvent* beforeInputEvent = InputEvent::createBeforeInput(
-      inputType, nullAtom, InputEvent::EventCancelable::IsCancelable,
+      inputType, nullAtom, inputTypeIsCancelable(inputType),
       InputEvent::EventIsComposing::NotComposing, ranges);
   return target->dispatchEvent(beforeInputEvent);
 }
 
 DispatchEventResult dispatchBeforeInputDataTransfer(
     Node* target,
     InputEvent::InputType inputType,
     DataTransfer* dataTransfer) {
   if (!RuntimeEnabledFeatures::inputEventEnabled())
     return DispatchEventResult::NotCanceled;
   if (!target)
     return DispatchEventResult::NotCanceled;
 
   DCHECK(inputType == InputEvent::InputType::InsertFromPaste ||
          inputType == InputEvent::InputType::InsertReplacementText ||
          inputType == InputEvent::InputType::InsertFromDrop ||
          inputType == InputEvent::InputType::DeleteByCut)
       << "Unsupported inputType: " << (int)inputType;
 
   InputEvent* beforeInputEvent;
 
   if (hasRichlyEditableStyle(*(target->toNode())) || !dataTransfer) {
     beforeInputEvent = InputEvent::createBeforeInput(
-        inputType, dataTransfer, InputEvent::EventCancelable::IsCancelable,
+        inputType, dataTransfer, inputTypeIsCancelable(inputType),
         InputEvent::EventIsComposing::NotComposing,
         targetRangesForInputEvent(*target));
   } else {
     const String& data = dataTransfer->getData(mimeTypeTextPlain);
     // TODO(chongz): Pass appropriate |ranges| after it's defined on spec.
     // http://w3c.github.io/editing/input-events.html#dom-inputevent-inputtype
     beforeInputEvent = InputEvent::createBeforeInput(
-        inputType, data, InputEvent::EventCancelable::IsCancelable,
+        inputType, data, inputTypeIsCancelable(inputType),
         InputEvent::EventIsComposing::NotComposing,
         targetRangesForInputEvent(*target));
   }
   return target->dispatchEvent(beforeInputEvent);
 }
 
 InputEvent::InputType deletionInputTypeFromTextGranularity(
     DeleteDirection direction,
     TextGranularity granularity) {
   using InputType = InputEvent::InputType;
   switch (direction) {
     case DeleteDirection::Forward:
       if (granularity == WordGranularity)
         return InputType::DeleteWordForward;
       if (granularity == LineBoundary)
         return InputType::DeleteLineForward;
       return InputType::DeleteContentForward;
     case DeleteDirection::Backward:
       if (granularity == WordGranularity)
         return InputType::DeleteWordBackward;
       if (granularity == LineBoundary)
         return InputType::DeleteLineBackward;
       return InputType::DeleteContentBackward;
     default:
       return InputType::None;
   }
 }
 
 }  // namespace blink