Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 2704573003: Revert of [turbofan] extend escape analysis to reduce CheckMaps (Closed)

Created:
3 years, 10 months ago by Jarin
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] extend escape analysis to reduce CheckMaps (patchset #7 id:140001 of https://codereview.chromium.org/2680973013/ ) Reason for revert: Likely causing http://crbug.com/692254 BUG=chromium:692254 Original issue's description: > [turbofan] extend escape analysis to reduce CheckMaps > > R=bmeurer@chromium.org > > BUG= > > Review-Url: https://codereview.chromium.org/2680973013 > Cr-Commit-Position: refs/heads/master@{#43163} > Committed: https://chromium.googlesource.com/v8/v8/+/f01c8a6e4b24ab38e58bb141fc251bc6b75dbe21 TBR=bmeurer@chromium.org,tebbi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Review-Url: https://codereview.chromium.org/2704573003 Cr-Commit-Position: refs/heads/master@{#43282} Committed: https://chromium.googlesource.com/v8/v8/+/ded072f4711fc8a2a48153c5412c6bda3a0b4c37

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -80 lines) Patch
M src/compiler/escape-analysis.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/compiler/escape-analysis.cc View 7 chunks +2 lines, -59 lines 0 comments Download
M src/compiler/escape-analysis-reducer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/escape-analysis-reducer.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Jarin
Created Revert of [turbofan] extend escape analysis to reduce CheckMaps
3 years, 10 months ago (2017-02-17 14:06:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704573003/1
3 years, 10 months ago (2017-02-17 14:06:21 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 14:34:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ded072f4711fc8a2a48153c5412c6bda3a0...

Powered by Google App Engine
This is Rietveld 408576698