[turbofan] extend escape analysis to reduce CheckMaps

[turbofan] extend escape analysis to reduce CheckMaps

R=bmeurer@chromium.org

BUG=

Review-Url: https://codereview.chromium.org/2680973013
Cr-Original-Commit-Position: refs/heads/master@{#43163}
Committed: https://chromium.googlesource.com/v8/v8/+/f01c8a6e4b24ab38e58bb141fc251bc6b75dbe21
Review-Url: https://codereview.chromium.org/2680973013
Cr-Commit-Position: refs/heads/master@{#43478}
Committed: https://chromium.googlesource.com/v8/v8/+/9881b6c740a7bcc2f9bb9ea696a0d9014e1e596c

[Tobias Tebbi, 2017-02-10 13:59:32]

The CQ bit was checked by tebbi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 13:59:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 14:02:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 14:02:49]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/22376)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)

[Benedikt Meurer, 2017-02-10 20:07:58]

LGTM, although I'd prefer to encapsulate this (even the constant foldable case)
in a CheckMapsValue operator.

[Tobias Tebbi, 2017-02-13 14:24:33]

Patchset #4 (id:60001) has been deleted

[Tobias Tebbi, 2017-02-13 14:25:53]

The CQ bit was checked by tebbi@chromium.org

[Tobias Tebbi, 2017-02-13 14:25:53]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2680973013/#ps80001
(title: "fixed load bug")

[Tobias Tebbi, 2017-02-13 14:25:56]

The CQ bit was unchecked by tebbi@chromium.org

[commit-bot: I haz the power, 2017-02-13 14:25:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tobias Tebbi, 2017-02-13 14:25:58]

The CQ bit was checked by tebbi@chromium.org

[commit-bot: I haz the power, 2017-02-13 14:26:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 14:28:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 14:28:47]

Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/22472)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/22564)

[Benedikt Meurer, 2017-02-13 15:02:01]

https://codereview.chromium.org/2680973013/diff/100001/src/compiler/escape-an...
File src/compiler/escape-analysis-reducer.cc (right):

https://codereview.chromium.org/2680973013/diff/100001/src/compiler/escape-an...
src/compiler/escape-analysis-reducer.cc:190: Node* object =
NodeProperties::GetValueInput(node, 0);
This looks wrong. Input 0 is the size.

https://codereview.chromium.org/2680973013/diff/100001/src/compiler/escape-an...
File src/compiler/escape-analysis.cc (right):

https://codereview.chromium.org/2680973013/diff/100001/src/compiler/escape-an...
src/compiler/escape-analysis.cc:1541: return;
Please add a TRACE message here. And a to-do that we want to extend this with
CheckMapsValue operator.

[Tobias Tebbi, 2017-02-13 15:35:07]

The CQ bit was checked by tebbi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 15:35:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tobias Tebbi, 2017-02-13 15:43:25]

On 2017/02/13 15:02:01, Benedikt Meurer wrote:
>
https://codereview.chromium.org/2680973013/diff/100001/src/compiler/escape-an...
> File src/compiler/escape-analysis-reducer.cc (right):
> 
>
https://codereview.chromium.org/2680973013/diff/100001/src/compiler/escape-an...
> src/compiler/escape-analysis-reducer.cc:190: Node* object =
> NodeProperties::GetValueInput(node, 0);
> This looks wrong. Input 0 is the size.

Thank you! I accidentally added code to the wrong function... Luckily, this also
failed in our test-suite.

>
https://codereview.chromium.org/2680973013/diff/100001/src/compiler/escape-an...
> File src/compiler/escape-analysis.cc (right):
> 
>
https://codereview.chromium.org/2680973013/diff/100001/src/compiler/escape-an...
> src/compiler/escape-analysis.cc:1541: return;
> Please add a TRACE message here. And a to-do that we want to extend this with
> CheckMapsValue operator.

done

[commit-bot: I haz the power, 2017-02-13 15:57:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 15:57:51]

Dry run: This issue passed the CQ dry run.

[Tobias Tebbi, 2017-02-13 15:59:12]

The CQ bit was checked by tebbi@chromium.org

[Tobias Tebbi, 2017-02-13 15:59:12]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2680973013/#ps140001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-02-13 15:59:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 16:00:56]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1487001552140280,
"parent_rev": "d170c57ab996d00c4665a9d865bd5754a1806c6c", "commit_rev":
"f01c8a6e4b24ab38e58bb141fc251bc6b75dbe21"}

[commit-bot: I haz the power, 2017-02-13 16:01:01]

Description was changed from

==========
[turbofan] extend escape analysis to reduce CheckMaps

R=bmeurer@chromium.org

BUG=
==========

to

==========
[turbofan] extend escape analysis to reduce CheckMaps

R=bmeurer@chromium.org

BUG=

Review-Url: https://codereview.chromium.org/2680973013
Cr-Commit-Position: refs/heads/master@{#43163}
Committed:
https://chromium.googlesource.com/v8/v8/+/f01c8a6e4b24ab38e58bb141fc251bc6b75...
==========

[commit-bot: I haz the power, 2017-02-13 16:01:02]

Committed patchset #7 (id:140001) as
https://chromium.googlesource.com/v8/v8/+/f01c8a6e4b24ab38e58bb141fc251bc6b75...

[Jarin, 2017-02-17 14:06:14]

A revert of this CL (patchset #7 id:140001) has been created in
https://codereview.chromium.org/2704573003/ by jarin@chromium.org.

The reason for reverting is: Likely causing http://crbug.com/692254

BUG=chromium:692254.

[Tobias Tebbi, 2017-02-28 12:07:27]

Description was changed from

==========
[turbofan] extend escape analysis to reduce CheckMaps

R=bmeurer@chromium.org

BUG=

Review-Url: https://codereview.chromium.org/2680973013
Cr-Commit-Position: refs/heads/master@{#43163}
Committed:
https://chromium.googlesource.com/v8/v8/+/f01c8a6e4b24ab38e58bb141fc251bc6b75...
==========

to

==========
[turbofan] extend escape analysis to reduce CheckMaps

R=bmeurer@chromium.org

BUG=

Review-Url: https://codereview.chromium.org/2680973013
Cr-Commit-Position: refs/heads/master@{#43163}
Committed:
https://chromium.googlesource.com/v8/v8/+/f01c8a6e4b24ab38e58bb141fc251bc6b75...
==========

[Tobias Tebbi, 2017-02-28 12:08:44]

Hi, could you take another look? I added a new flag and staged the feature
behind it.

Adding a trivial test case to enable Clusterfuzz to discover the flag.

[Benedikt Meurer, 2017-02-28 12:14:12]

Still LGTM.

[Tobias Tebbi, 2017-02-28 12:15:26]

The CQ bit was checked by tebbi@chromium.org

[commit-bot: I haz the power, 2017-02-28 12:15:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 12:44:02]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1488284126629060,
"parent_rev": "3c36aacc87f701fea0bb6976a4498dde61929a29", "commit_rev":
"9881b6c740a7bcc2f9bb9ea696a0d9014e1e596c"}

[commit-bot: I haz the power, 2017-02-28 12:44:09]

Description was changed from

==========
[turbofan] extend escape analysis to reduce CheckMaps

R=bmeurer@chromium.org

BUG=

Review-Url: https://codereview.chromium.org/2680973013
Cr-Commit-Position: refs/heads/master@{#43163}
Committed:
https://chromium.googlesource.com/v8/v8/+/f01c8a6e4b24ab38e58bb141fc251bc6b75...
==========

to

==========
[turbofan] extend escape analysis to reduce CheckMaps

R=bmeurer@chromium.org

BUG=

Review-Url: https://codereview.chromium.org/2680973013
Cr-Original-Commit-Position: refs/heads/master@{#43163}
Committed:
https://chromium.googlesource.com/v8/v8/+/f01c8a6e4b24ab38e58bb141fc251bc6b75...
Review-Url: https://codereview.chromium.org/2680973013
Cr-Commit-Position: refs/heads/master@{#43478}
Committed:
https://chromium.googlesource.com/v8/v8/+/9881b6c740a7bcc2f9bb9ea696a0d9014e1...
==========

[commit-bot: I haz the power, 2017-02-28 12:44:11]

Committed patchset #9 (id:180001) as
https://chromium.googlesource.com/v8/v8/+/9881b6c740a7bcc2f9bb9ea696a0d9014e1...