Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 2704573002: Deprecate FileReaderSync in service workers. (Closed)

Created:
3 years, 10 months ago by Marijn Kruisselbrink
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Deprecate FileReaderSync in service workers. Intent to deprecate and remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/cjWtqRD6iw8/hcxtAeE2CAAJ BUG=688586 Review-Url: https://codereview.chromium.org/2680363003 Cr-Commit-Position: refs/heads/master@{#450593} (cherry picked from commit d039981e6de2c11e1dfdc1c0f6ba61804cc92c49) Review-Url: https://codereview.chromium.org/2704573002 . Cr-Commit-Position: refs/branch-heads/2987@{#555} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/389c6611afa3e464d8e6c7fb2eda6f02d6e8cdc9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Marijn Kruisselbrink
3 years, 10 months ago (2017-02-16 19:55:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
389c6611afa3e464d8e6c7fb2eda6f02d6e8cdc9.

Powered by Google App Engine
This is Rietveld 408576698