Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2680363003: Deprecate FileReaderSync in service workers. (Closed)

Created:
3 years, 10 months ago by Marijn Kruisselbrink
Modified:
3 years, 10 months ago
Reviewers:
Mark P, foolip
CC:
asvitkine+watch_chromium.org, blink-reviews, chromium-reviews, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate FileReaderSync in service workers. Intent to deprecate and remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/cjWtqRD6iw8/hcxtAeE2CAAJ BUG=688586 Review-Url: https://codereview.chromium.org/2680363003 Cr-Commit-Position: refs/heads/master@{#450593} Committed: https://chromium.googlesource.com/chromium/src/+/d039981e6de2c11e1dfdc1c0f6ba61804cc92c49

Patch Set 1 #

Patch Set 2 : add chromestatus.com entry #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
Marijn Kruisselbrink
3 years, 10 months ago (2017-02-14 19:23:38 UTC) #10
Mark P
histograms.xml lgtm
3 years, 10 months ago (2017-02-14 19:26:22 UTC) #12
foolip
lgtm
3 years, 10 months ago (2017-02-15 05:48:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680363003/40001
3 years, 10 months ago (2017-02-15 05:48:33 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 06:29:04 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d039981e6de2c11e1dfdc1c0f6ba...

Powered by Google App Engine
This is Rietveld 408576698