Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2704443005: Selection API: Show a deprecation message for a quirky addRange() behavior. (Closed)

Created:
3 years, 10 months ago by tkent
Modified:
3 years, 10 months ago
Reviewers:
yoichio, yosin_UTC9
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Selection API: Show a deprecation message for a quirky addRange() behavior. BUG=693315 Review-Url: https://codereview.chromium.org/2704443005 Cr-Commit-Position: refs/heads/master@{#451256} Committed: https://chromium.googlesource.com/chromium/src/+/6b7e091709d04f852f7572556c8dc6c1e8790fbb

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/editing/selection/addRange-merging-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/addRange-00-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/addRange-04-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/addRange-12-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/addRange-16-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/addRange-20-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/addRange-24-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/addRange-28-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/addRange-32-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/addRange-36-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/first-letter-rtc-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/full-screen-contentEditable-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/editing/selection/addRange-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/selection/addRange-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/editing/selection/addRange-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
tkent
yoichio@ or yosin@, would you review this please? I'll try to merge this to M57 ...
3 years, 10 months ago (2017-02-17 04:08:08 UTC) #11
yosin_UTC9
lgtm Thanks for quick work!
3 years, 10 months ago (2017-02-17 04:43:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704443005/40001
3 years, 10 months ago (2017-02-17 06:24:14 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 07:06:04 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6b7e091709d04f852f7572556c8d...

Powered by Google App Engine
This is Rietveld 408576698