Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: third_party/WebKit/Source/core/editing/DOMSelection.cpp

Issue 2704443005: Selection API: Show a deprecation message for a quirky addRange() behavior. (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/DOMSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/DOMSelection.cpp b/third_party/WebKit/Source/core/editing/DOMSelection.cpp
index 8d1a24704a2080ce07acdbb13d972dded6a10509..338e6d7a23932b86002a258fa555b14b43c2491d 100644
--- a/third_party/WebKit/Source/core/editing/DOMSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/DOMSelection.cpp
@@ -39,6 +39,7 @@
#include "core/editing/EditingUtilities.h"
#include "core/editing/FrameSelection.h"
#include "core/editing/iterators/TextIterator.h"
+#include "core/frame/Deprecation.h"
#include "core/frame/LocalFrame.h"
#include "core/frame/UseCounter.h"
#include "core/inspector/ConsoleMessage.h"
@@ -616,7 +617,8 @@ void DOMSelection::addRange(Range* newRange) {
// really do the same, since we don't support discontiguous selection. Further
// discussions at
// <https://code.google.com/p/chromium/issues/detail?id=353069>.
- UseCounter::count(frame(), UseCounter::SelectionAddRangeIntersect);
+ Deprecation::countDeprecation(frame(),
+ UseCounter::SelectionAddRangeIntersect);
Range* start = originalRange->compareBoundaryPoints(
Range::kStartToStart, newRange, ASSERT_NO_EXCEPTION) < 0

Powered by Google App Engine
This is Rietveld 408576698