Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 2704343003: Catch up the spec update in CSS Rhythmic Sizing (Closed)
Patch Set: Sorted CSSProperties.json5 alphabetically (meade@'s nit) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
index f93e329d6930aba981aa31fad2d7a673f1b4228a..5b6fea71243dac070b684e0c90a74b5024d99f54 100644
--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
@@ -2532,6 +2532,8 @@ const CSSValue* ComputedStyleCSSValueMapping::get(
: CSSPrimitiveValue::UnitType::Number);
case CSSPropertyLineHeight:
return valueForLineHeight(style);
+ case CSSPropertyLineHeightStep:
+ return zoomAdjustedPixelValue(style.lineHeightStep(), style);
case CSSPropertyListStyleImage:
if (style.listStyleImage())
return style.listStyleImage()->computedCSSValue();
@@ -3646,18 +3648,6 @@ const CSSValue* ComputedStyleCSSValueMapping::get(
ASSERT(list->length());
return list;
}
- case CSSPropertySnapHeight: {
- if (!style.snapHeightUnit())
- return CSSPrimitiveValue::create(0,
- CSSPrimitiveValue::UnitType::Pixels);
- CSSValueList* list = CSSValueList::createSpaceSeparated();
- list->append(*CSSPrimitiveValue::create(
- style.snapHeightUnit(), CSSPrimitiveValue::UnitType::Pixels));
- if (style.snapHeightPosition())
- list->append(*CSSPrimitiveValue::create(
- style.snapHeightPosition(), CSSPrimitiveValue::UnitType::Integer));
- return list;
- }
case CSSPropertyVariable:
// Variables are retrieved via get(AtomicString).
ASSERT_NOT_REACHED();

Powered by Google App Engine
This is Rietveld 408576698