Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2704213002: [devtools] Allow transparent base background color overrides. (Closed)

Created:
3 years, 10 months ago by Eric Seckler
Modified:
3 years, 10 months ago
Reviewers:
dgozman
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[devtools] Allow transparent base background color overrides. BUG=689349 Review-Url: https://codereview.chromium.org/2704213002 Cr-Commit-Position: refs/heads/master@{#452008} Committed: https://chromium.googlesource.com/chromium/src/+/6b9bfb533a084798aaccb0de0dc3575c377dbc34

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -7 lines) Patch
M third_party/WebKit/Source/web/InspectorEmulationAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 5 chunks +20 lines, -6 lines 2 comments Download

Messages

Total messages: 17 (10 generated)
Eric Seckler
Dmitry, PTAL.
3 years, 10 months ago (2017-02-20 15:47:24 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2704213002/diff/1/third_party/WebKit/Source/web/WebViewImpl.cpp File third_party/WebKit/Source/web/WebViewImpl.cpp (right): https://codereview.chromium.org/2704213002/diff/1/third_party/WebKit/Source/web/WebViewImpl.cpp#newcode2450 third_party/WebKit/Source/web/WebViewImpl.cpp:2450: return baseBackgroundColor().rgb(); Nice one!
3 years, 10 months ago (2017-02-21 19:41:44 UTC) #7
Eric Seckler
Thanks! :) https://codereview.chromium.org/2704213002/diff/1/third_party/WebKit/Source/web/WebViewImpl.cpp File third_party/WebKit/Source/web/WebViewImpl.cpp (right): https://codereview.chromium.org/2704213002/diff/1/third_party/WebKit/Source/web/WebViewImpl.cpp#newcode2450 third_party/WebKit/Source/web/WebViewImpl.cpp:2450: return baseBackgroundColor().rgb(); On 2017/02/21 19:41:44, dgozman wrote: ...
3 years, 10 months ago (2017-02-22 09:19:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704213002/1
3 years, 10 months ago (2017-02-22 09:21:02 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/369854)
3 years, 10 months ago (2017-02-22 11:14:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704213002/1
3 years, 10 months ago (2017-02-22 11:28:02 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 12:12:43 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6b9bfb533a084798aaccb0de0dc3...

Powered by Google App Engine
This is Rietveld 408576698