[devtools] Allow transparent base background color overrides.

[devtools] Allow transparent base background color overrides.

BUG=689349
Review-Url: https://codereview.chromium.org/2704213002
Cr-Commit-Position: refs/heads/master@{#452008}
Committed: https://chromium.googlesource.com/chromium/src/+/6b9bfb533a084798aaccb0de0dc3575c377dbc34

[Eric Seckler, 2017-02-20 15:47:24]

eseckler@chromium.org changed reviewers:
+ dgozman@chromium.org

[Eric Seckler, 2017-02-20 15:47:24]

Dmitry, PTAL.

[Eric Seckler, 2017-02-20 16:16:53]

The CQ bit was checked by eseckler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 16:17:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 17:53:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 17:53:43]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-02-21 19:41:44]

lgtm

https://codereview.chromium.org/2704213002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/2704213002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebViewImpl.cpp:2450: return
baseBackgroundColor().rgb();
Nice one!

[Eric Seckler, 2017-02-22 09:19:30]

Thanks! :)

https://codereview.chromium.org/2704213002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/2704213002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebViewImpl.cpp:2450: return
baseBackgroundColor().rgb();
On 2017/02/21 19:41:44, dgozman wrote:
> Nice one!

yeah ... I should have seen that in the first place really :)

[Eric Seckler, 2017-02-22 09:19:36]

The CQ bit was checked by eseckler@chromium.org

[commit-bot: I haz the power, 2017-02-22 09:21:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 11:14:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 11:14:54]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Eric Seckler, 2017-02-22 11:27:42]

The CQ bit was checked by eseckler@chromium.org

[commit-bot: I haz the power, 2017-02-22 11:28:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 12:12:06]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487762862291330, "parent_rev":
"57a268525e7960919de4d9f161d5369b11e39ab6", "commit_rev":
"6b9bfb533a084798aaccb0de0dc3575c377dbc34"}

[commit-bot: I haz the power, 2017-02-22 12:12:42]

Description was changed from

==========
[devtools] Allow transparent base background color overrides.

BUG=689349
==========

to

==========
[devtools] Allow transparent base background color overrides.

BUG=689349

Review-Url: https://codereview.chromium.org/2704213002
Cr-Commit-Position: refs/heads/master@{#452008}
Committed:
https://chromium.googlesource.com/chromium/src/+/6b9bfb533a084798aaccb0de0dc3...
==========

[commit-bot: I haz the power, 2017-02-22 12:12:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6b9bfb533a084798aaccb0de0dc3...