third_party/WebKit/Source/web/InspectorEmulationAgent.cpp - Issue 2704213002: [devtools] Allow transparent base background color overrides.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/InspectorEmulationAgent.cpp

Issue 2704213002: [devtools] Allow transparent base background color overrides. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/InspectorEmulationAgent.cpp

diff --git a/third_party/WebKit/Source/web/InspectorEmulationAgent.cpp b/third_party/WebKit/Source/web/InspectorEmulationAgent.cpp

index f2bbfe4b4ee75b6590921f7ff31219a014342071..174661efd175e51193ba36e67b8d1a98ce4b3e7c 100644

--- a/third_party/WebKit/Source/web/InspectorEmulationAgent.cpp

+++ b/third_party/WebKit/Source/web/InspectorEmulationAgent.cpp

@@ -188,7 +188,7 @@ Response InspectorEmulationAgent::setDefaultBackgroundColorOverride(

Maybe<protocol::DOM::RGBA> color) {

if (!color.isJust()) {

// Clear the override and state.

- webViewImpl()->setBaseBackgroundColorOverride(Color::transparent);

+ webViewImpl()->clearBaseBackgroundColorOverride();

m_state->remove(EmulationAgentState::defaultBackgroundColorOverrideRGBA);

return Response::OK();

}