gm/rebaseline_server/imagepairset.py - Issue 270413002: rebaseline_server JSON: pass category values as values, not keys

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/rebaseline_server/imagepairset.py

Issue 270413002: rebaseline_server JSON: pass category values as values, not keys (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gm/rebaseline_server/imagepairset.py

diff --git a/gm/rebaseline_server/imagepairset.py b/gm/rebaseline_server/imagepairset.py

index 04aea903423bb05e70eeef94ad7df81da0902d75..880987703d968041378470e266644a976001bdf5 100644

--- a/gm/rebaseline_server/imagepairset.py

+++ b/gm/rebaseline_server/imagepairset.py

@@ -17,7 +17,6 @@ import column

# Keys used within dictionary representation of ImagePairSet.

# NOTE: Keep these in sync with static/constants.js

-KEY__EXTRACOLUMNHEADERS = 'extraColumnHeaders'

KEY__IMAGEPAIRS = 'imagePairs'

KEY__IMAGESETS = 'imageSets'

KEY__IMAGESETS__FIELD__BASE_URL = 'baseUrl'

@@ -141,7 +140,7 @@ class ImagePairSet(object):

key_description = KEY__IMAGESETS__FIELD__DESCRIPTION

key_base_url = KEY__IMAGESETS__FIELD__BASE_URL

return {

- KEY__EXTRACOLUMNHEADERS: self._column_headers_as_dict(),

+ column.KEY__EXTRACOLUMNHEADERS: self._column_headers_as_dict(),

KEY__IMAGEPAIRS: self._image_pair_dicts,

KEY__IMAGESETS: {

KEY__IMAGESETS__SET__IMAGE_A: {

« no previous file with comments | « gm/rebaseline_server/compare_to_expectations.py ('k') | gm/rebaseline_server/imagepairset_test.py » ('j') | no next file with comments »