gm/rebaseline_server/imagepairset_test.py - Issue 270413002: rebaseline_server JSON: pass category values as values, not keys

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/rebaseline_server/imagepairset_test.py

Issue 270413002: rebaseline_server JSON: pass category values as values, not keys (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gm/rebaseline_server/imagepairset_test.py

diff --git a/gm/rebaseline_server/imagepairset_test.py b/gm/rebaseline_server/imagepairset_test.py

index c046ec7c7cf6e5e24587439ada4d0c7599fb7912..d7aeb64fea8f4d09773de1120136b9dec84dc30f 100755

--- a/gm/rebaseline_server/imagepairset_test.py

+++ b/gm/rebaseline_server/imagepairset_test.py

@@ -91,9 +91,7 @@ class ImagePairSetTest(unittest.TestCase):

'headerText': 'builder',

'isFilterable': True,

'isSortable': True,

- 'valuesAndCounts': {

- 'MyBuilder': 3

- },

+ 'valuesAndCounts': [('MyBuilder', 3)],

'test': {

'headerText': 'which GM test',

« no previous file with comments | « gm/rebaseline_server/imagepairset.py ('k') | gm/rebaseline_server/results.py » ('j') | no next file with comments »