gm/rebaseline_server/compare_to_expectations.py - Issue 270413002: rebaseline_server JSON: pass category values as values, not keys

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/rebaseline_server/compare_to_expectations.py

Issue 270413002: rebaseline_server JSON: pass category values as values, not keys (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gm/rebaseline_server/compare_to_expectations.py

diff --git a/gm/rebaseline_server/compare_to_expectations.py b/gm/rebaseline_server/compare_to_expectations.py

index ab05f6f51b597835f2d1e9a895cdc0e635bb3194..cddca55d2a1cea27ac48aab20adee70c446ba2e0 100755

--- a/gm/rebaseline_server/compare_to_expectations.py

+++ b/gm/rebaseline_server/compare_to_expectations.py

@@ -316,6 +316,8 @@ class ExpectationComparisons(results.BaseComparisons):

# categories recorded within the gm_actuals AT ALL, and

# instead evaluate the result_type ourselves based on what

# we see in expectations vs actual checksum?

+ # See related http://skbug.com/2514 ('rebaseline_server: apply

+ # ignored-tests.txt within rebaseline_server, not just on the bots')

if expected_image_relative_url == actual_image_relative_url:

updated_result_type = results.KEY__RESULT_TYPE__SUCCEEDED

else:

« no previous file with comments | « gm/rebaseline_server/column.py ('k') | gm/rebaseline_server/imagepairset.py » ('j') | no next file with comments »