Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: gm/rebaseline_server/static/view.html

Issue 270413002: rebaseline_server JSON: pass category values as values, not keys (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gm/rebaseline_server/static/view.html
diff --git a/gm/rebaseline_server/static/view.html b/gm/rebaseline_server/static/view.html
index 0b2476c534da14746446d46692dcbeaa27661556..8440fea88979e21091856d066215a657012b38d7 100644
--- a/gm/rebaseline_server/static/view.html
+++ b/gm/rebaseline_server/static/view.html
@@ -63,13 +63,14 @@
<tr valign="top">
<td>
resultType<br>
- <label ng-repeat="(resultType, count) in extraColumnHeaders[constants.KEY__EXTRACOLUMN__RESULT_TYPE][constants.KEY__VALUES_AND_COUNTS] track by $index">
+ <label ng-repeat="value in extraColumnHeaders[constants.KEY__EXTRACOLUMN__RESULT_TYPE][constants.KEY__EXTRACOLUMNHEADERS__VALUES]">
<input type="checkbox"
name="resultTypes"
- value="{{resultType}}"
- ng-checked="!isValueInSet(resultType, hiddenResultTypes)"
- ng-click="toggleValueInSet(resultType, hiddenResultTypes); setUpdatesPending(true)">
- {{resultType}} ({{count}})<br>
+ value="{{value}}"
+ ng-checked="!isValueInSet(value, hiddenResultTypes)"
+ ng-click="toggleValueInSet(value, hiddenResultTypes); setUpdatesPending(true)">
+ {{value}}
+ ({{extraColumnHeaders[constants.KEY__EXTRACOLUMN__RESULT_TYPE][constants.KEY__EXTRACOLUMNHEADERS__COUNTS][$index]}})<br>
</label>
<button ng-click="hiddenResultTypes = {}; updateResults()">
all
@@ -95,13 +96,14 @@
</td>
<td>
config<br>
- <label ng-repeat="(config, count) in extraColumnHeaders[constants.KEY__EXTRACOLUMN__CONFIG][constants.KEY__VALUES_AND_COUNTS] track by $index">
+ <label ng-repeat="value in extraColumnHeaders[constants.KEY__EXTRACOLUMN__CONFIG][constants.KEY__EXTRACOLUMNHEADERS__VALUES]">
<input type="checkbox"
name="configs"
- value="{{config}}"
- ng-checked="!isValueInSet(config, hiddenConfigs)"
- ng-click="toggleValueInSet(config, hiddenConfigs); setUpdatesPending(true)">
- {{config}} ({{count}})<br>
+ value="{{value}}"
+ ng-checked="!isValueInSet(value, hiddenConfigs)"
+ ng-click="toggleValueInSet(value, hiddenConfigs); setUpdatesPending(true)">
+ {{value}}
+ ({{extraColumnHeaders[constants.KEY__EXTRACOLUMN__CONFIG][constants.KEY__EXTRACOLUMNHEADERS__COUNTS][$index]}})<br>
</label>
<button ng-click="hiddenConfigs = {}; updateResults()">
all

Powered by Google App Engine
This is Rietveld 408576698