Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: gm/rebaseline_server/static/view.html

Issue 270413002: rebaseline_server JSON: pass category values as values, not keys (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« gm/rebaseline_server/static/constants.js ('K') | « gm/rebaseline_server/static/loader.js ('k') | gm/rebaseline_server/testdata/outputs/expected/compare_configs_test.CompareConfigsTest.test_gm/gm.json » ('j') | gm/rebaseline_server/utils.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 2
3 <html ng-app="Loader" ng-controller="Loader.Controller"> 3 <html ng-app="Loader" ng-controller="Loader.Controller">
4 4
5 <head> 5 <head>
6 <title ng-bind="windowTitle"></title> 6 <title ng-bind="windowTitle"></title>
7 <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.1.5/angular.js" ></script> 7 <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.1.5/angular.js" ></script>
8 <script src="constants.js"></script> 8 <script src="constants.js"></script>
9 <script src="loader.js"></script> 9 <script src="loader.js"></script>
10 <link rel="stylesheet" href="view.css"> 10 <link rel="stylesheet" href="view.css">
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 <th colspan="4"> 56 <th colspan="4">
57 Filters 57 Filters
58 </th> 58 </th>
59 <th> 59 <th>
60 Settings 60 Settings
61 </th> 61 </th>
62 </tr> 62 </tr>
63 <tr valign="top"> 63 <tr valign="top">
64 <td> 64 <td>
65 resultType<br> 65 resultType<br>
66 <label ng-repeat="(resultType, count) in extraColumnHeaders[constants.KE Y__EXTRACOLUMN__RESULT_TYPE][constants.KEY__VALUES_AND_COUNTS] track by $index"> 66 <label ng-repeat="value in extraColumnHeaders[constants.KEY__EXTRACOLUMN __RESULT_TYPE][constants.KEY__EXTRACOLUMNHEADERS__VALUES]">
67 <input type="checkbox" 67 <input type="checkbox"
68 name="resultTypes" 68 name="resultTypes"
69 value="{{resultType}}" 69 value="{{value}}"
70 ng-checked="!isValueInSet(resultType, hiddenResultTypes)" 70 ng-checked="!isValueInSet(value, hiddenResultTypes)"
71 ng-click="toggleValueInSet(resultType, hiddenResultTypes); setU pdatesPending(true)"> 71 ng-click="toggleValueInSet(value, hiddenResultTypes); setUpdate sPending(true)">
72 {{resultType}} ({{count}})<br> 72 {{value}}
73 ({{extraColumnHeaders[constants.KEY__EXTRACOLUMN__RESULT_TYPE][constan ts.KEY__EXTRACOLUMNHEADERS__COUNTS][$index]}})<br>
73 </label> 74 </label>
74 <button ng-click="hiddenResultTypes = {}; updateResults()"> 75 <button ng-click="hiddenResultTypes = {}; updateResults()">
75 all 76 all
76 </button> 77 </button>
77 <button ng-click="hiddenResultTypes = {}; toggleValuesInSet(allResultTyp es, hiddenResultTypes); updateResults()"> 78 <button ng-click="hiddenResultTypes = {}; toggleValuesInSet(allResultTyp es, hiddenResultTypes); updateResults()">
78 none 79 none
79 </button> 80 </button>
80 <button ng-click="toggleValuesInSet(allResultTypes, hiddenResultTypes); updateResults()"> 81 <button ng-click="toggleValuesInSet(allResultTypes, hiddenResultTypes); updateResults()">
81 toggle 82 toggle
82 </button> 83 </button>
83 </td> 84 </td>
84 <td ng-repeat="category in [constants.KEY__EXTRACOLUMN__BUILDER, constants .KEY__EXTRACOLUMN__TEST]"> 85 <td ng-repeat="category in [constants.KEY__EXTRACOLUMN__BUILDER, constants .KEY__EXTRACOLUMN__TEST]">
85 {{category}} 86 {{category}}
86 <br> 87 <br>
87 <input type="text" 88 <input type="text"
88 ng-model="categoryValueMatch[category]" 89 ng-model="categoryValueMatch[category]"
89 ng-change="setUpdatesPending(true)"/> 90 ng-change="setUpdatesPending(true)"/>
90 <br> 91 <br>
91 <button ng-click="setCategoryValueMatch(category, '')" 92 <button ng-click="setCategoryValueMatch(category, '')"
92 ng-disabled="('' == categoryValueMatch[category])"> 93 ng-disabled="('' == categoryValueMatch[category])">
93 clear (show all) 94 clear (show all)
94 </button> 95 </button>
95 </td> 96 </td>
96 <td> 97 <td>
97 config<br> 98 config<br>
98 <label ng-repeat="(config, count) in extraColumnHeaders[constants.KEY__E XTRACOLUMN__CONFIG][constants.KEY__VALUES_AND_COUNTS] track by $index"> 99 <label ng-repeat="value in extraColumnHeaders[constants.KEY__EXTRACOLUMN __CONFIG][constants.KEY__EXTRACOLUMNHEADERS__VALUES]">
99 <input type="checkbox" 100 <input type="checkbox"
100 name="configs" 101 name="configs"
101 value="{{config}}" 102 value="{{value}}"
102 ng-checked="!isValueInSet(config, hiddenConfigs)" 103 ng-checked="!isValueInSet(value, hiddenConfigs)"
103 ng-click="toggleValueInSet(config, hiddenConfigs); setUpdatesPe nding(true)"> 104 ng-click="toggleValueInSet(value, hiddenConfigs); setUpdatesPen ding(true)">
104 {{config}} ({{count}})<br> 105 {{value}}
106 ({{extraColumnHeaders[constants.KEY__EXTRACOLUMN__CONFIG][constants.KE Y__EXTRACOLUMNHEADERS__COUNTS][$index]}})<br>
105 </label> 107 </label>
106 <button ng-click="hiddenConfigs = {}; updateResults()"> 108 <button ng-click="hiddenConfigs = {}; updateResults()">
107 all 109 all
108 </button> 110 </button>
109 <button ng-click="hiddenConfigs = {}; toggleValuesInSet(allConfigs, hidd enConfigs); updateResults()"> 111 <button ng-click="hiddenConfigs = {}; toggleValuesInSet(allConfigs, hidd enConfigs); updateResults()">
110 none 112 none
111 </button> 113 </button>
112 <button ng-click="toggleValuesInSet(allConfigs, hiddenConfigs); updateRe sults()"> 114 <button ng-click="toggleValuesInSet(allConfigs, hiddenConfigs); updateRe sults()">
113 toggle 115 toggle
114 </button> 116 </button>
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
414 ng-click="toggleValueInArray(imagePair.index, selectedImagePa irs)"> 416 ng-click="toggleValueInArray(imagePair.index, selectedImagePa irs)">
415 </tr> 417 </tr>
416 </table> <!-- imagePairs --> 418 </table> <!-- imagePairs -->
417 </td></tr></table> <!-- table holding results header + imagePairs table --> 419 </td></tr></table> <!-- table holding results header + imagePairs table -->
418 420
419 </div><!-- main display area of selected tab --> 421 </div><!-- main display area of selected tab -->
420 </div><!-- everything: hide until data is loaded --> 422 </div><!-- everything: hide until data is loaded -->
421 423
422 </body> 424 </body>
423 </html> 425 </html>
OLDNEW
« gm/rebaseline_server/static/constants.js ('K') | « gm/rebaseline_server/static/loader.js ('k') | gm/rebaseline_server/testdata/outputs/expected/compare_configs_test.CompareConfigsTest.test_gm/gm.json » ('j') | gm/rebaseline_server/utils.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698