Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: gm/rebaseline_server/static/loader.js

Issue 270413002: rebaseline_server JSON: pass category values as values, not keys (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gm/rebaseline_server/static/loader.js
diff --git a/gm/rebaseline_server/static/loader.js b/gm/rebaseline_server/static/loader.js
index dc33bd0a93a971b01cf303e86627953ee8d0589f..d3c2405a9702403617080e3add0b14ae07148052 100644
--- a/gm/rebaseline_server/static/loader.js
+++ b/gm/rebaseline_server/static/loader.js
@@ -148,13 +148,13 @@ Loader.controller(
constants.KEY__RESULT_TYPE__NOCOMPARISON] = true;
$scope.hiddenResultTypes[
constants.KEY__RESULT_TYPE__SUCCEEDED] = true;
- $scope.allResultTypes = Object.keys(
+ $scope.allResultTypes =
$scope.extraColumnHeaders[constants.KEY__EXTRACOLUMN__RESULT_TYPE]
- [constants.KEY__VALUES_AND_COUNTS]);
+ [constants.KEY__EXTRACOLUMNHEADERS__VALUES];
$scope.hiddenConfigs = {};
- $scope.allConfigs = Object.keys(
+ $scope.allConfigs =
$scope.extraColumnHeaders[constants.KEY__EXTRACOLUMN__CONFIG]
- [constants.KEY__VALUES_AND_COUNTS]);
+ [constants.KEY__EXTRACOLUMNHEADERS__VALUES];
// Associative array of partial string matches per category.
$scope.categoryValueMatch = {};

Powered by Google App Engine
This is Rietveld 408576698