third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommandTest.cpp - Issue 2704123003: Expand FrameSeleciton::isCaret() to increase chances of hoisting update layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommandTest.cpp

Issue 2704123003: Expand FrameSeleciton::isCaret() to increase chances of hoisting update layout (Closed)

Patch Set: 2017-02-21T12:50:46 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp ('k') | third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommandTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommandTest.cpp b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommandTest.cpp

index d9851afd5e31be552240941e7fb6874d6d07c9a2..6dfd318df47b25fa66a5a19c28317e7a7a60a09f 100644

--- a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommandTest.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommandTest.cpp

@@ -54,7 +54,9 @@ TEST_F(DeleteSelectionCommandTest, deleteListFromTable) {

EXPECT_TRUE(command->apply()) << "the delete command should have succeeded";

EXPECT_EQ("<div contenteditable=\"true\"><br></div>",

document().body()->innerHTML());

- EXPECT_TRUE(frame->selection().isCaret());

+ EXPECT_TRUE(frame->selection()

+ .computeVisibleSelectionInDOMTreeDeprecated()

+ .isCaret());

EXPECT_EQ(Position(div, 0), frame->selection().base().toOffsetInAnchor());

}