Some improvements to the command-line analyzer's output.

Some improvements to the command-line analyzer's output.

BUG=
R=brianwilkerson@google.com, danrubel@google.com

Committed: https://github.com/dart-lang/sdk/commit/46cacfeae93310b09b52d8fca2b8f9348f230a5e

[devoncarew, 2017-02-19 22:28:34]

devoncarew@google.com changed reviewers:
+ brianwilkerson@google.com, danrubel@google.com, pquitslund@google.com

[devoncarew, 2017-02-19 22:28:35]

Some improvements to the command-line analyzer's output:
- refactoring some code into a new 'error_severity.dart' library, to tease apart
analyzer_impl.dart and build_mode.dart
- fix the initial 'Analyzing...' output, so it says 'Analyzing foo...' instead
of 'Analyzing [foo]...'
- research into the duplicate analysis errors issue (#25697); possibly related
to a change to make the analysis run faster in batch mode on the bots. The fix
may involve a lot of refactoring. For now, added a (failing) test showing the
issue
- 2 cli flags moved to the hidden section

Change issue output from
"[warning] 'foo' is not a... (/Users/.../tmp/foo.dart, line 1, col 2)"
to
"[warning] 'foo' is not a bar at lib/foo.dart:1:2 (foo_warning)."
- paths which can be printed as relative paths are
- include the error code
- line and column info more terse, and in a format that IntelliJ can link to
- corrections added in verbose mode

[Brian Wilkerson, 2017-02-19 22:52:17]

lgtm once the imports have been fixed

https://codereview.chromium.org/2704103002/diff/1/pkg/analyzer_cli/lib/src/an...
File pkg/analyzer_cli/lib/src/analyzer_impl.dart (right):

https://codereview.chromium.org/2704103002/diff/1/pkg/analyzer_cli/lib/src/an...
pkg/analyzer_cli/lib/src/analyzer_impl.dart:25: import 'options.dart';
Import directives inside a package that reference a file in that package's 'lib'
directory should be 'package:' imports.

https://codereview.chromium.org/2704103002/diff/1/pkg/analyzer_cli/lib/src/an...
pkg/analyzer_cli/lib/src/analyzer_impl.dart:227: // TODO(devoncarew): This is
never called.
Then it should be removed, unless someone knows of a reason to keep it.

https://codereview.chromium.org/2704103002/diff/1/pkg/analyzer_cli/lib/src/dr...
File pkg/analyzer_cli/lib/src/driver.dart (right):

https://codereview.chromium.org/2704103002/diff/1/pkg/analyzer_cli/lib/src/dr...
pkg/analyzer_cli/lib/src/driver.dart:229: files.forEach((file) {
It looks like this CL is also removing the non-driver path. Is that intentional?

https://codereview.chromium.org/2704103002/diff/1/pkg/analyzer_cli/lib/src/er...
File pkg/analyzer_cli/lib/src/error_severity.dart (right):

https://codereview.chromium.org/2704103002/diff/1/pkg/analyzer_cli/lib/src/er...
pkg/analyzer_cli/lib/src/error_severity.dart:22: //
https://github.com/dart-lang/sdk/issues/26215
nit: please indent internal comments so that they don't look like doc comments.

[devoncarew, 2017-02-21 04:30:47]

Driver (inadvertent) change reverted, and changed the package imports back

https://codereview.chromium.org/2704103002/diff/1/pkg/analyzer_cli/lib/src/an...
File pkg/analyzer_cli/lib/src/analyzer_impl.dart (right):

https://codereview.chromium.org/2704103002/diff/1/pkg/analyzer_cli/lib/src/an...
pkg/analyzer_cli/lib/src/analyzer_impl.dart:25: import 'options.dart';
On 2017/02/19 22:52:17, Brian Wilkerson wrote:
> Import directives inside a package that reference a file in that package's
'lib'
> directory should be 'package:' imports.

That's true for things outside of 'lib' (like tool, bin,...). Inside of 'lib' I
often see relative paths being used.  From just browsing quickly, here's an
example:
https://github.com/dart-lang/bazel/blob/master/dazel/lib/src/bazelify/build.dart.

But since this change isn't the purpose of this CL, I'll back it out.

https://codereview.chromium.org/2704103002/diff/1/pkg/analyzer_cli/lib/src/dr...
File pkg/analyzer_cli/lib/src/driver.dart (right):

https://codereview.chromium.org/2704103002/diff/1/pkg/analyzer_cli/lib/src/dr...
pkg/analyzer_cli/lib/src/driver.dart:229: files.forEach((file) {
On 2017/02/19 22:52:17, Brian Wilkerson wrote:
> It looks like this CL is also removing the non-driver path. Is that
intentional?

No - it's unintentional. I had a fair amount of changes to try and fix the
duplicate analysis issues bug; looks like those changes didn't get completely
backed out.

https://codereview.chromium.org/2704103002/diff/1/pkg/analyzer_cli/lib/src/er...
File pkg/analyzer_cli/lib/src/error_severity.dart (right):

https://codereview.chromium.org/2704103002/diff/1/pkg/analyzer_cli/lib/src/er...
pkg/analyzer_cli/lib/src/error_severity.dart:22: //
https://github.com/dart-lang/sdk/issues/26215
On 2017/02/19 22:52:17, Brian Wilkerson wrote:
> nit: please indent internal comments so that they don't look like doc
comments.

updated. This happened via copy and paste; strangely enough dartfmt doesn't fix
the indents.

[danrubel, 2017-02-21 13:14:17]

LGTM

[Brian Wilkerson, 2017-02-21 15:26:43]

lgtm

https://codereview.chromium.org/2704103002/diff/20001/pkg/analyzer_cli/lib/sr...
File pkg/analyzer_cli/lib/src/driver.dart (right):

https://codereview.chromium.org/2704103002/diff/20001/pkg/analyzer_cli/lib/sr...
pkg/analyzer_cli/lib/src/driver.dart:251: // be reported multiple times
(#25697).
I have an idea for one possible solution if you're interested in looking into
this (and don't already have an idea).

https://codereview.chromium.org/2704103002/diff/20001/pkg/analyzer_cli/lib/sr...
pkg/analyzer_cli/lib/src/driver.dart:486: // TODO(devoncarew): This needs to
respect analysis_options excludes.
Does it? I think that when we're expanding a directory we should, but generally
speaking I think that command-line options should override the options in the
analysis options file. It would be useful to be able to force the analysis of a
file that would otherwise be excluded by explicitly specifying it.

https://codereview.chromium.org/2704103002/diff/20001/pkg/analyzer_cli/lib/sr...
File pkg/analyzer_cli/lib/src/error_formatter.dart (right):

https://codereview.chromium.org/2704103002/diff/20001/pkg/analyzer_cli/lib/sr...
pkg/analyzer_cli/lib/src/error_formatter.dart:185: sourceName =
source.uri.toString();
You might want to check that the URI isn't a "file:" URI.

[devoncarew, 2017-02-22 20:35:16]

Description was changed from

==========
Some improvements to the command-line analyzer's output.

BUG=
==========

to

==========
Some improvements to the command-line analyzer's output.

BUG=
R=brianwilkerson@google.com, danrubel@google.com

Committed:
https://github.com/dart-lang/sdk/commit/46cacfeae93310b09b52d8fca2b8f9348f230a5e
==========

[devoncarew, 2017-02-22 20:35:17]

Committed patchset #2 (id:20001) manually as
46cacfeae93310b09b52d8fca2b8f9348f230a5e (presubmit successful).