Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: pkg/analyzer_cli/test/reporter_test.dart

Issue 2704103002: Some improvements to the command-line analyzer's output. (Closed)
Patch Set: review comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer_cli/test/reporter_test.dart
diff --git a/pkg/analyzer_cli/test/reporter_test.dart b/pkg/analyzer_cli/test/reporter_test.dart
index 7e9070fe42eb6c0c34174d71755baf76ab396604..078f36da05fb46034dded2c145017cdab550084f 100644
--- a/pkg/analyzer_cli/test/reporter_test.dart
+++ b/pkg/analyzer_cli/test/reporter_test.dart
@@ -24,6 +24,7 @@ main() {
when(options.enableTypeChecks).thenReturn(false);
when(options.hintsAreFatal).thenReturn(false);
when(options.machineFormat).thenReturn(false);
+ when(options.verbose).thenReturn(false);
var reporter = new ErrorFormatter(out, options, stats);
@@ -32,7 +33,7 @@ main() {
reporter.formatErrors([error]);
expect(out.toString().trim(),
- '[error] MSG (/foo/bar/baz.dart, line 3, col 3)');
+ '[error] MSG at /foo/bar/baz.dart:3:3 (mock_code).');
});
test('hint', () {
@@ -40,7 +41,7 @@ main() {
reporter.formatErrors([error]);
expect(out.toString().trim(),
- '[hint] MSG (/foo/bar/baz.dart, line 3, col 3)');
+ '[hint] MSG at /foo/bar/baz.dart:3:3 (mock_code).');
});
test('stats', () {
@@ -49,8 +50,8 @@ main() {
stats.print(out);
expect(
out.toString().trim(),
- '''[hint] MSG (/foo/bar/baz.dart, line 3, col 3)
-1 hint found.''');
+ '[hint] MSG at /foo/bar/baz.dart:3:3 (mock_code).\n'
+ '1 hint found.');
});
});
}

Powered by Google App Engine
This is Rietveld 408576698