Some improvements to the command-line analyzer's output.

pkg/analyzer_cli/lib/src/analyzer_impl.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer_cli.src.analyzer_impl;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:io';
 
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/error/error.dart';
 import 'package:analyzer/exception/exception.dart';
-import 'package:analyzer/source/error_processor.dart';
 import 'package:analyzer/src/dart/analysis/driver.dart';
-import 'package:analyzer/src/error/codes.dart';
 import 'package:analyzer/src/generated/engine.dart' hide AnalysisResult;
 import 'package:analyzer/src/generated/java_io.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/src/generated/source_io.dart';
 import 'package:analyzer/src/generated/utilities_general.dart';
-import 'package:analyzer_cli/src/driver.dart';
-import 'package:analyzer_cli/src/error_formatter.dart';
-import 'package:analyzer_cli/src/options.dart';
-import 'package:path/path.dart' as pathos;
+import 'package:path/path.dart' as path;
 
-/// The maximum number of sources for which AST structures should be kept in the cache.
-const int _maxCacheSize = 512;
+import 'driver.dart';
+import 'error_formatter.dart';
+import 'error_severity.dart';
+import 'options.dart';

[Brian Wilkerson, 2017/02/19 22:52:17]

Import directives inside a package that reference a file in that package's 'lib'
directory should be 'package:' imports.

[devoncarew, 2017/02/21 04:30:47]

That's true for things outside of 'lib' (like tool, bin,...). Inside of 'lib' I
often see relative paths being used.  From just browsing quickly, here's an
example:
https://github.com/dart-lang/bazel/blob/master/dazel/lib/src/bazelify/build.dart.

But since this change isn't the purpose of this CL, I'll back it out.

 
-int currentTimeMillis() => new DateTime.now().millisecondsSinceEpoch;
+int get currentTimeMillis => new DateTime.now().millisecondsSinceEpoch;
 
 /// Analyzes single library [File].
 class AnalyzerImpl {
   static final PerformanceTag _prepareErrorsTag =
       new PerformanceTag("AnalyzerImpl.prepareErrors");
   static final PerformanceTag _resolveLibraryTag =
       new PerformanceTag("AnalyzerImpl._resolveLibrary");
 
   final CommandLineOptions options;
   final int startTime;
@@ skipping 69 matching lines @@
     for (LibraryElement child in library.importedLibraries) {
       addLibrarySources(child, libraries, units);
     }
     for (LibraryElement child in library.exportedLibraries) {
       addLibrarySources(child, libraries, units);
     }
   }
 
   /// Treats the [sourcePath] as the top level library and analyzes it using
   /// the analysis engine. If [printMode] is `0`, then no error or performance
-  /// information is printed. If [printMode] is `1`, then both will be printed.
-  /// If [printMode] is `2`, then only performance information will be printed,
-  /// and it will be marked as being for a cold VM.
+  /// information is printed. If [printMode] is `1`, then errors will be printed.
+  /// If [printMode] is `2`, then performance information will be printed, and
+  /// it will be marked as being for a cold VM.
   Future<ErrorSeverity> analyze({int printMode: 1}) async {
     setupForAnalysis();
     return await _analyze(printMode);
   }
 
   /// Fills [errorInfos] using [sources].
   Future<Null> prepareErrors() async {
     PerformanceTag previous = _prepareErrorsTag.makeCurrent();
     try {
       for (Source source in sources) {
@@ skipping 87 matching lines @@
       return true;
     } else if (!options.showPackageWarnings) {
       return false;
     } else if (options.showPackageWarningsPrefix == null) {
       return true;
     } else {
       return packageName.startsWith(options.showPackageWarningsPrefix);
     }
   }
 
-  _printColdPerf() {
+  // TODO(devoncarew): This is never called.

[Brian Wilkerson, 2017/02/19 22:52:17]

Then it should be removed, unless someone knows of a reason to keep it.

+  void _printColdPerf() {
     // Print cold VM performance numbers.
-    int totalTime = currentTimeMillis() - startTime;
+    int totalTime = currentTimeMillis - startTime;
     int otherTime = totalTime;
     for (PerformanceTag tag in PerformanceTag.all) {
       if (tag != PerformanceTag.UNKNOWN) {
         int tagTime = tag.elapsedMs;
         outSink.writeln('${tag.label}-cold:$tagTime');
         otherTime -= tagTime;
       }
     }
     outSink.writeln('other-cold:$otherTime');
     outSink.writeln("total-cold:$totalTime");
   }
 
-  _printErrors() {
+  void _printErrors() {
     // The following is a hack. We currently print out to stderr to ensure that
     // when in batch mode we print to stderr, this is because the prints from
     // batch are made to stderr. The reason that options.shouldBatch isn't used
     // is because when the argument flags are constructed in BatchRunner and
     // passed in from batch mode which removes the batch flag to prevent the
     // "cannot have the batch flag and source file" error message.
     StringSink sink = options.machineFormat ? errorSink : outSink;
 
     // Print errors.
     ErrorFormatter formatter =
@@ skipping 14 matching lines @@
             await analysisDriver.getUnitElement(path);
         return elementResult.element.library;
       } else {
         return context.computeLibraryElement(librarySource);
       }
     } finally {
       previous.makeCurrent();
     }
   }
 
-  /// Compute the severity of the error; however:
-  ///   * if [options.enableTypeChecks] is false, then de-escalate checked-mode
-  ///   compile time errors to a severity of [ErrorSeverity.INFO].
-  ///   * if [options.hintsAreFatal] is true, escalate hints to errors.
-  ///   * if [options.lintsAreFatal] is true, escalate lints to errors.
-  static ErrorSeverity computeSeverity(
-      AnalysisError error, CommandLineOptions options,
-      [AnalysisOptions analysisOptions]) {
-    if (analysisOptions != null) {
-      ErrorProcessor processor =
-          ErrorProcessor.getProcessor(analysisOptions, error);
-      // If there is a processor for this error, defer to it.
-      if (processor != null) {
-        return processor.severity;
-      }
-    }
-
-    if (!options.enableTypeChecks &&
-        error.errorCode.type == ErrorType.CHECKED_MODE_COMPILE_TIME_ERROR) {
-      return ErrorSeverity.INFO;
-    } else if (options.hintsAreFatal && error.errorCode is HintCode) {
-      return ErrorSeverity.ERROR;
-    } else if (options.lintsAreFatal && error.errorCode is LintCode) {
-      return ErrorSeverity.ERROR;
-    }
-    return error.errorCode.errorSeverity;
-  }
-
   /// Return the corresponding package directory or `null` if none is found.
   static JavaFile getPackageDirectoryFor(JavaFile sourceFile) {
     // We are going to ask parent file, so get absolute path.
     sourceFile = sourceFile.getAbsoluteFile();
     // Look in the containing directories.
     JavaFile dir = sourceFile.getParentFile();
     while (dir != null) {
       JavaFile packagesDir = new JavaFile.relative(dir, "packages");
       if (packagesDir.exists()) {
         return packagesDir;
       }
       dir = dir.getParentFile();
     }
     // Not found.
     return null;
   }
 
-  /// Check various configuration options to get a desired severity for this
-  /// [error] (or `null` if it's to be suppressed).
-  static ProcessedSeverity processError(AnalysisError error,
-      CommandLineOptions options, AnalysisOptions analysisOptions) {
-    ErrorSeverity severity = computeSeverity(error, options, analysisOptions);
-    bool isOverridden = false;
-
-    // Skip TODOs categorically (unless escalated to ERROR or HINT.)
-    // https://github.com/dart-lang/sdk/issues/26215
-    if (error.errorCode.type == ErrorType.TODO &&
-        severity == ErrorSeverity.INFO) {
-      return null;
-    }
-
-    // First check for a filter.
-    if (severity == null) {
-      // Null severity means the error has been explicitly ignored.
-      return null;
-    } else {
-      isOverridden = true;
-    }
-
-    // If not overridden, some "natural" severities get globally filtered.
-    if (!isOverridden) {
-      // Check for global hint filtering.
-      if (severity == ErrorSeverity.INFO && options.disableHints) {
-        return null;
-      }
-    }
-
-    return new ProcessedSeverity(severity, isOverridden);
-  }
-
-  /// Return `true` if the given [path] is in the Pub cache.
-  static bool _isPathInPubCache(String path) {
-    List<String> parts = pathos.split(path);
+  /// Return `true` if the given [pathName] is in the Pub cache.
+  static bool _isPathInPubCache(String pathName) {
+    List<String> parts = path.split(pathName);
     if (parts.contains('.pub-cache')) {
       return true;
     }
     for (int i = 0; i < parts.length - 2; i++) {
       if (parts[i] == 'Pub' && parts[i + 1] == 'Cache') {
         return true;
       }
     }
     return false;
   }
@@ skipping 13 matching lines @@
   }
 
   @override
   void logInformation(String message, [CaughtException exception]) {
     outSink.writeln(message);
     if (exception != null) {
       outSink.writeln(exception);
     }
   }
 }