Fix a crash due to reentrancy in the widget while processing a theme changed notification after com…

Fix a crash due to reentrancy in the widget while processing a theme changed notification after coming out of fullscreen mode

The crash occurs as views are removed/added while we are propagating theme changed notifications to the view hierarchy.

Proposed fix is to add a recursion guard flag processing_theme_changed_ which is set in
Widget::OnNativeThemeUpdated before propagating the theme changed notification and reset after
the function returns. We check the flag in Widget::FrameTypeChanged() and bail. This function is called becaue
Widget is registered as an observer on the BrowserView.

BUG=681525
Review-Url: https://codereview.chromium.org/2703933002
Cr-Commit-Position: refs/heads/master@{#451505}
Committed: https://chromium.googlesource.com/chromium/src/+/f7c7217dd882eac40d5d07e441db5ef9fe3c94a4

[ananta, 2017-02-17 22:49:21]

ananta@chromium.org changed reviewers:
+ sky@chromium.org

[ananta, 2017-02-17 22:49:29]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[sky, 2017-02-17 22:50:03]

LGTM

https://codereview.chromium.org/2703933002/diff/1/ui/views/widget/widget.cc
File ui/views/widget/widget.cc (right):

https://codereview.chromium.org/2703933002/diff/1/ui/views/widget/widget.cc#n...
ui/views/widget/widget.cc:1408: processing_theme_changed_ = true;
Use AutoReset.

[commit-bot: I haz the power, 2017-02-17 22:50:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ananta, 2017-02-17 22:55:04]

https://codereview.chromium.org/2703933002/diff/1/ui/views/widget/widget.cc
File ui/views/widget/widget.cc (right):

https://codereview.chromium.org/2703933002/diff/1/ui/views/widget/widget.cc#n...
ui/views/widget/widget.cc:1408: processing_theme_changed_ = true;
On 2017/02/17 22:50:03, sky wrote:
> Use AutoReset.

Done.

[ananta, 2017-02-17 22:55:12]

The CQ bit was checked by ananta@chromium.org

[ananta, 2017-02-17 22:55:12]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2703933002/#ps20001
(title: "Use AutoReset")

[commit-bot: I haz the power, 2017-02-17 22:55:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 00:58:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 00:58:29]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[ananta, 2017-02-18 01:15:54]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2017-02-18 01:17:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 03:19:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 03:19:33]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[ananta, 2017-02-19 00:38:52]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2017-02-19 00:39:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-19 02:43:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487464732837410,
"parent_rev": "6b9501df29d056a886b6d30ebb3b5a86daa8685d", "commit_rev":
"f7c7217dd882eac40d5d07e441db5ef9fe3c94a4"}

[commit-bot: I haz the power, 2017-02-19 02:44:46]

Description was changed from

==========
Fix a crash due to reentrancy in the widget while processing a theme changed
notification after coming out of fullscreen mode

The crash occurs as views are removed/added while we are propagating theme
changed notifications to the view hierarchy.

Proposed fix is to add a recursion guard flag processing_theme_changed_ which is
set in
Widget::OnNativeThemeUpdated before propagating the theme changed notification
and reset after
the function returns. We check the flag in Widget::FrameTypeChanged() and bail.
This function is called becaue
Widget is registered as an observer on the BrowserView.

BUG=681525
==========

to

==========
Fix a crash due to reentrancy in the widget while processing a theme changed
notification after coming out of fullscreen mode

The crash occurs as views are removed/added while we are propagating theme
changed notifications to the view hierarchy.

Proposed fix is to add a recursion guard flag processing_theme_changed_ which is
set in
Widget::OnNativeThemeUpdated before propagating the theme changed notification
and reset after
the function returns. We check the flag in Widget::FrameTypeChanged() and bail.
This function is called becaue
Widget is registered as an observer on the BrowserView.

BUG=681525

Review-Url: https://codereview.chromium.org/2703933002
Cr-Commit-Position: refs/heads/master@{#451505}
Committed:
https://chromium.googlesource.com/chromium/src/+/f7c7217dd882eac40d5d07e441db...
==========

[commit-bot: I haz the power, 2017-02-19 02:44:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f7c7217dd882eac40d5d07e441db...