Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: ui/views/widget/widget.h

Issue 2703933002: Fix a crash due to reentrancy in the widget while processing a theme changed notification after com… (Closed)
Patch Set: Use AutoReset Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/views/widget/widget.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_VIEWS_WIDGET_WIDGET_H_ 5 #ifndef UI_VIEWS_WIDGET_WIDGET_H_
6 #define UI_VIEWS_WIDGET_WIDGET_H_ 6 #define UI_VIEWS_WIDGET_WIDGET_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <set> 10 #include <set>
(...skipping 974 matching lines...) Expand 10 before | Expand all | Expand 10 after
985 985
986 // Does |views_with_layers_| need updating? 986 // Does |views_with_layers_| need updating?
987 bool views_with_layers_dirty_; 987 bool views_with_layers_dirty_;
988 988
989 // True when window movement via mouse interaction with the frame should be 989 // True when window movement via mouse interaction with the frame should be
990 // disabled. 990 // disabled.
991 bool movement_disabled_; 991 bool movement_disabled_;
992 992
993 ScopedObserver<ui::NativeTheme, ui::NativeThemeObserver> observer_manager_; 993 ScopedObserver<ui::NativeTheme, ui::NativeThemeObserver> observer_manager_;
994 994
995 // Guard to avoid reentrancy while processing a theme changed message.
996 bool processing_theme_changed_;
997
995 DISALLOW_COPY_AND_ASSIGN(Widget); 998 DISALLOW_COPY_AND_ASSIGN(Widget);
996 }; 999 };
997 1000
998 } // namespace views 1001 } // namespace views
999 1002
1000 #endif // UI_VIEWS_WIDGET_WIDGET_H_ 1003 #endif // UI_VIEWS_WIDGET_WIDGET_H_
OLDNEW
« no previous file with comments | « no previous file | ui/views/widget/widget.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698