Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2703833002: Migrate WTF::HashSet::remove() to ::erase() [part 2] (Closed)

Created:
3 years, 10 months ago by pilgrim_google
Modified:
3 years, 10 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-wtf_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, falken+watch_chromium.org, horo+watch_chromium.org, jchaffraix+rendering, kinuko+watch, kinuko+fileapi, kinuko+worker_chromium.org, leviw+renderwatch, mcasas+watch+mediastream_chromium.org, Mikhail, nhiroki, pdr+renderingwatchlist_chromium.org, rwlbuis, shimazu+worker_chromium.org, sof, szager+layoutwatch_chromium.org, tommyw+watchlist_chromium.org, tzik, webcomponents-bugzilla_chromium.org, zoltan1, jsbell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::HashSet::remove() to ::erase() [part 2] As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Review-Url: https://codereview.chromium.org/2703833002 Cr-Commit-Position: refs/heads/master@{#451817} Committed: https://chromium.googlesource.com/chromium/src/+/d13bd4b7858208f2fb37cfea437e06b8a95902bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -22 lines) Patch
M third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/DepthOrderedLayoutObjectList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USB.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/HashSet.h View 4 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/AtomicStringTable.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
pilgrim_google
3 years, 10 months ago (2017-02-17 18:28:00 UTC) #3
sof
lgtm
3 years, 10 months ago (2017-02-17 18:39:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703833002/1
3 years, 10 months ago (2017-02-17 20:37:30 UTC) #10
haraken
LGTM
3 years, 10 months ago (2017-02-17 22:54:16 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-17 23:07:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703833002/1
3 years, 10 months ago (2017-02-21 17:08:33 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 19:26:13 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d13bd4b7858208f2fb37cfea437e...

Powered by Google App Engine
This is Rietveld 408576698