third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp - Issue 2703833002: Migrate WTF::HashSet::remove() to ::erase() [part 2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp

Issue 2703833002: Migrate WTF::HashSet::remove() to ::erase() [part 2] (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp ('k') | third_party/WebKit/Source/core/fileapi/FileReader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp

index 0ba4e345a66ea59afed345fc430608a3d1d156c6..6fdc2e1064ea313da727a131a24158f7ab5f65d2 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp

@@ -68,7 +68,7 @@ void CustomElementUpgradeSorter::visit(HeapVector<Member<Element>>* result,

if (it->get()->isElementNode() && m_elements->contains(toElement(*it)))

result->push_back(toElement(*it));

sorted(result, *it);

- children.remove(it);

+ children.erase(it);

}

void CustomElementUpgradeSorter::sorted(HeapVector<Member<Element>>* result,

« no previous file with comments | « third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp ('k') | third_party/WebKit/Source/core/fileapi/FileReader.cpp » ('j') | no next file with comments »