Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2703803002: Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests. (Closed)

Created:
3 years, 10 months ago by zakerinasab
Modified:
3 years, 9 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests. This change replaces js-test.js assertions with testharness.js assertions. The expectation files are removed as they are not needed anymore. To simplify review and landing, each change corrects at most 10 tests. BUG=639732 Review-Url: https://codereview.chromium.org/2703803002 Cr-Commit-Position: refs/heads/master@{#453234} Committed: https://chromium.googlesource.com/chromium/src/+/02df18b202939d3508fcecd0ac839b21f93ba54f

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -597 lines) Patch
M third_party/WebKit/LayoutTests/fast/canvas/fallback-content.html View 2 chunks +40 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/fallback-content-expected.txt View 1 chunk +0 lines, -78 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/fillText-shadow.html View 1 chunk +33 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/fillText-shadow-expected.txt View 1 chunk +0 lines, -65 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/getPutImageDataPairTest.html View 3 chunks +31 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/getPutImageDataPairTest-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/gradient-addColorStop-with-invalid-color.html View 1 chunk +17 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/gradient-addColorStop-with-invalid-color-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/gradient-addColorStop-with-invalid-offset.html View 1 chunk +15 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/gradient-addColorStop-with-invalid-offset-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/gradient-with-clip.html View 1 chunk +48 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/gradient-with-clip-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/image-pattern-rotate.html View 2 chunks +24 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/image-pattern-rotate-expected.txt View 1 chunk +0 lines, -53 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/imagedata-contains-uint8clampedarray.html View 1 chunk +11 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/imagedata-contains-uint8clampedarray-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/invalid-set-font-crash.html View 1 1 chunk +16 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/invalid-set-font-crash-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/linearGradient-infinite-values.html View 1 chunk +30 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/linearGradient-infinite-values-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/gradient-addColorStop-with-invalid-color.js View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/gradient-addColorStop-with-invalid-offset.js View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/gradient-with-clip.js View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/linearGradient-infinite-values.js View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Justin Novosad
lgtm + nit https://codereview.chromium.org/2703803002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/invalid-set-font-crash.html File third_party/WebKit/LayoutTests/fast/canvas/invalid-set-font-crash.html (right): https://codereview.chromium.org/2703803002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/invalid-set-font-crash.html#newcode13 third_party/WebKit/LayoutTests/fast/canvas/invalid-set-font-crash.html:13: window.onload = function() { inconsistent indent
3 years, 10 months ago (2017-02-24 21:25:55 UTC) #3
zakerinasab
Comments addressed. Landing. https://codereview.chromium.org/2703803002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/invalid-set-font-crash.html File third_party/WebKit/LayoutTests/fast/canvas/invalid-set-font-crash.html (right): https://codereview.chromium.org/2703803002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/invalid-set-font-crash.html#newcode13 third_party/WebKit/LayoutTests/fast/canvas/invalid-set-font-crash.html:13: window.onload = function() { On 2017/02/24 ...
3 years, 9 months ago (2017-02-27 15:40:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703803002/20001
3 years, 9 months ago (2017-02-27 15:40:31 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 16:46:21 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/02df18b202939d3508fcecd0ac83...

Powered by Google App Engine
This is Rietveld 408576698