Add strings to be used on the new version of Incognito NTP.

Add strings to be used on the new version of Incognito NTP.

- Title
- Subtitle
- Disclaimer
- Two lists of bulletpoints

Note that each list of bulletpoints is represented as one string to ensure
translation consistency; the wording used for the title of the list can
affect on the declension of individual bullet points.

The UI where the strings will be used is not a part of this CL.

BUG=693525
Review-Url: https://codereview.chromium.org/2703733004
Cr-Commit-Position: refs/heads/master@{#453285}
Committed: https://chromium.googlesource.com/chromium/src/+/cfe102adddc5a18fc2cc6c453e5342450895aa4b

[msramek, 2017-02-17 15:00:39]

Patchset #2 (id:20001) has been deleted

[msramek, 2017-02-17 15:00:51]

Patchset #1 (id:1) has been deleted

[msramek, 2017-02-17 15:02:36]

Description was changed from

==========
Add strings to be used on the new version of Incognito NTP.

- Title
- Subtitle
- Two lists of bulletpoints
- Footer

Note that each list of bulletpoints is represented as one string to ensure
translation consistency; the wording used for the title of the list can
affect on the declension of individual bullet points.

The UI where the strings will be used is not a part of this CL.

BUG=693525
==========

to

==========
Add strings to be used on the new version of Incognito NTP.

- Title
- Subtitle
- Disclaimer
- Two lists of bulletpoints

Note that each list of bulletpoints is represented as one string to ensure
translation consistency; the wording used for the title of the list can
affect on the declension of individual bullet points.

There are two copies of strings, one for Desktop and iOS (where the page
is implemented in HTML) and one for Android (in XML).

The UI where the strings will be used is not a part of this CL.

BUG=693525
==========

[msramek, 2017-02-17 15:14:55]

msramek@chromium.org changed reviewers:
+ nyquist@chromium.org, sdefresne@chromium.org

[msramek, 2017-02-17 15:14:56]

Hi Sylvain and Tommy,

Please have a look!

As far as I understand, Android XML layout files only use
android_chrome_strings.grdp, so this duplication is necessary. That is, after
all, how it's implemented for the current NTP as well. But please let me know if
it can be avoided.

Thanks,
Martin

[nyquist, 2017-02-17 19:09:50]

nyquist@chromium.org changed reviewers:
+ twellington@chromium.org

[nyquist, 2017-02-17 19:09:50]

twellington: Do you have any input on this? According to the author we already
duplicate the strings for the current NTP.

I have a vague memory about this being because the strings were different for
Android and the rest of Chrome earlier, but since this is supposed to be for iOS
as well, maybe they could be shared now?

[Theresa, 2017-02-17 19:27:30]

On 2017/02/17 19:09:50, nyquist wrote:
> twellington: Do you have any input on this? According to the author we already
> duplicate the strings for the current NTP.
> 
> I have a vague memory about this being because the strings were different for
> Android and the rest of Chrome earlier, but since this is supposed to be for
iOS
> as well, maybe they could be shared now?

It appears that we are currently using strings from
components/new_or_sad_tab_strings.grdp in Android XML (e.g. SAD_TAB_TITLE and
SAD_TAB_MESSAGE), so I don't think the strings need to be duplicated. I also did
a quick test to confirm that I am able to use strings in
new_or_sad_tab_strings.grdp in XML.

Martin, were you getting an error when trying to use strings in
new_or_sad_tab_strings.grdp in XML?

[msramek, 2017-02-20 13:55:28]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 13:55:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2017-02-20 14:05:51]

I searched a few random strings that I knew should be used on both Desktop and
Android, and all of those in my small sample were duplicated - including the
current incognito NTP strings. So thanks for finding a counterexample, Theresa
:)

What was missing from my strings in components/ was the
'formatter_data="android_java"' annotation - that's why it didn't work. Sorry
for the confusion!

I reverted the change in android_chrome_strings.grd, all strings are now in
components/. Sylvain, PTAL :)

[commit-bot: I haz the power, 2017-02-20 14:11:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 14:11:40]

Dry run: This issue passed the CQ dry run.

[msramek, 2017-02-27 13:50:42]

Sylvain, friendly ping!

[sdefresne, 2017-02-27 18:31:41]

lgtm

Please remove the following from the description:

> There are two copies of strings, one for Desktop and iOS (where the page
> is implemented in HTML) and one for Android (in XML).

[msramek, 2017-02-27 18:39:24]

Description was changed from

==========
Add strings to be used on the new version of Incognito NTP.

- Title
- Subtitle
- Disclaimer
- Two lists of bulletpoints

Note that each list of bulletpoints is represented as one string to ensure
translation consistency; the wording used for the title of the list can
affect on the declension of individual bullet points.

There are two copies of strings, one for Desktop and iOS (where the page
is implemented in HTML) and one for Android (in XML).

The UI where the strings will be used is not a part of this CL.

BUG=693525
==========

to

==========
Add strings to be used on the new version of Incognito NTP.

- Title
- Subtitle
- Disclaimer
- Two lists of bulletpoints

Note that each list of bulletpoints is represented as one string to ensure
translation consistency; the wording used for the title of the list can
affect on the declension of individual bullet points.

The UI where the strings will be used is not a part of this CL.

BUG=693525
==========

[msramek, 2017-02-27 18:40:29]

On 2017/02/27 18:31:41, sdefresne wrote:
> lgtm
> 
> Please remove the following from the description:
> 
> > There are two copies of strings, one for Desktop and iOS (where the page
> > is implemented in HTML) and one for Android (in XML).

Done. I keep forgetting about that. Thanks!

[msramek, 2017-02-27 18:40:37]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2017-02-27 18:41:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 19:13:50]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488220837224880,
"parent_rev": "3e6f43b480f54b4abe4b8a9e8d7e95abec31c2db", "commit_rev":
"cfe102adddc5a18fc2cc6c453e5342450895aa4b"}

[commit-bot: I haz the power, 2017-02-27 19:14:27]

Description was changed from

==========
Add strings to be used on the new version of Incognito NTP.

- Title
- Subtitle
- Disclaimer
- Two lists of bulletpoints

Note that each list of bulletpoints is represented as one string to ensure
translation consistency; the wording used for the title of the list can
affect on the declension of individual bullet points.

The UI where the strings will be used is not a part of this CL.

BUG=693525
==========

to

==========
Add strings to be used on the new version of Incognito NTP.

- Title
- Subtitle
- Disclaimer
- Two lists of bulletpoints

Note that each list of bulletpoints is represented as one string to ensure
translation consistency; the wording used for the title of the list can
affect on the declension of individual bullet points.

The UI where the strings will be used is not a part of this CL.

BUG=693525

Review-Url: https://codereview.chromium.org/2703733004
Cr-Commit-Position: refs/heads/master@{#453285}
Committed:
https://chromium.googlesource.com/chromium/src/+/cfe102adddc5a18fc2cc6c453e53...
==========

[commit-bot: I haz the power, 2017-02-27 19:14:28]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cfe102adddc5a18fc2cc6c453e53...