Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2703713003: Remove SafePointBarrier (Closed)

Created:
3 years, 10 months ago by haraken
Modified:
3 years, 10 months ago
Reviewers:
sof
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), haraken, blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SafePointBarrier We can simplify code by inlining what SafePointBarrier is doing in ThreadState.cpp. BUG=671856 Review-Url: https://codereview.chromium.org/2703713003 Cr-Commit-Position: refs/heads/master@{#451297} Committed: https://chromium.googlesource.com/chromium/src/+/ea1c7044e3c4df9325089a41d320f4892d5bf041

Patch Set 1 #

Total comments: 2

Patch Set 2 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -74 lines) Patch
M third_party/WebKit/Source/platform/heap/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/SafePoint.h View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/Source/platform/heap/SafePoint.cpp View 1 chunk +0 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 4 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
haraken
PTAL https://codereview.chromium.org/2703713003/diff/1/third_party/WebKit/Source/platform/heap/ThreadState.cpp File third_party/WebKit/Source/platform/heap/ThreadState.cpp (right): https://codereview.chromium.org/2703713003/diff/1/third_party/WebKit/Source/platform/heap/ThreadState.cpp#newcode1128 third_party/WebKit/Source/platform/heap/ThreadState.cpp:1128: // TODO(haraken): The first void* pointer is unused. ...
3 years, 10 months ago (2017-02-17 11:48:52 UTC) #2
sof
lgtm
3 years, 10 months ago (2017-02-17 11:56:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703713003/20001
3 years, 10 months ago (2017-02-17 12:08:43 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 14:02:50 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ea1c7044e3c4df9325089a41d320...

Powered by Google App Engine
This is Rietveld 408576698