Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2703673003: Revert of Work around one more callsite into PaintLayerClipper (Closed)

Created:
3 years, 10 months ago by Tom Anderson
Modified:
3 years, 10 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Work around one more callsite into PaintLayerClipper (patchset #1 id:1 of https://codereview.chromium.org/2702783002/ ) Reason for revert: Causing build failure: https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/33433 Original issue's description: > Work around one more callsite into PaintLayerClipper. > > This was causing crashes. > > BUG=691569 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2702783002 > Cr-Commit-Position: refs/heads/master@{#451364} > Committed: https://chromium.googlesource.com/chromium/src/+/d9fdf85698a5b75fd3236d9ea9d1faebfcf51242 TBR=pdr@chromium.org,chrishtr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=691569 Review-Url: https://codereview.chromium.org/2703673003 Cr-Commit-Position: refs/heads/master@{#451371} Committed: https://chromium.googlesource.com/chromium/src/+/2d2154016e7698707f9cafd55efe508948fd170c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Anderson
Created Revert of Work around one more callsite into PaintLayerClipper
3 years, 10 months ago (2017-02-17 20:30:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703673003/1
3 years, 10 months ago (2017-02-17 20:33:10 UTC) #3
chrishtr
Looks like my patch landed at the exact same time as the LayoutObject reference one. ...
3 years, 10 months ago (2017-02-17 20:34:03 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 20:34:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2d2154016e7698707f9cafd55efe...

Powered by Google App Engine
This is Rietveld 408576698