Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2702783002: Work around one more callsite into PaintLayerClipper (Closed)

Created:
3 years, 10 months ago by chrishtr
Modified:
3 years, 10 months ago
Reviewers:
pdr., Nico
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Work around one more callsite into PaintLayerClipper. This was causing crashes. BUG=691569 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2702783002 Cr-Commit-Position: refs/heads/master@{#451364} Committed: https://chromium.googlesource.com/chromium/src/+/d9fdf85698a5b75fd3236d9ea9d1faebfcf51242

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp View 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 20 (10 generated)
chrishtr
3 years, 10 months ago (2017-02-17 17:33:23 UTC) #5
pdr.
LGTM The other patch seems to have stuck, can you remove the other suppression code?
3 years, 10 months ago (2017-02-17 17:39:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702783002/1
3 years, 10 months ago (2017-02-17 19:37:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d9fdf85698a5b75fd3236d9ea9d1faebfcf51242
3 years, 10 months ago (2017-02-17 20:06:05 UTC) #13
Tom Anderson
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2703673003/ by thomasanderson@chromium.org. ...
3 years, 10 months ago (2017-02-17 20:30:50 UTC) #14
findit-for-me
FYI: Findit identified this CL at revision 451364 as the culprit for failures in the ...
3 years, 10 months ago (2017-02-17 20:35:40 UTC) #15
Nico
https://codereview.chromium.org/2702783002/diff/1/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp File third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp (right): https://codereview.chromium.org/2702783002/diff/1/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp#newcode515 third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp:515: return ClipRect(LayoutRect(LayoutRect::infiniteIntRect())); https://build.chromium.org/p/chromium.fyi/builders/Linux%20ARM/builds/34587/steps/compile/logs/stdio FAILED: obj/third_party/WebKit/Source/core/paint/paint_1/PaintLayerClipper.o /b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF ...
3 years, 10 months ago (2017-02-17 21:14:24 UTC) #17
chrishtr
This CL has already been reverted, you just need to sync.
3 years, 10 months ago (2017-02-17 21:15:09 UTC) #18
Nico
Cool, thanks, sorry about missing that :-( On Fri, Feb 17, 2017 at 4:15 PM, ...
3 years, 10 months ago (2017-02-17 21:16:04 UTC) #19
Nico
3 years, 10 months ago (2017-02-17 21:16:05 UTC) #20
Message was sent while issue was closed.
Cool, thanks, sorry about missing that :-(

On Fri, Feb 17, 2017 at 4:15 PM, <chrishtr@chromium.org> wrote:

> This CL has already been reverted, you just need to sync.
>
> https://codereview.chromium.org/2702783002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698