[WPT Export] Use github remote, not origin

[WPT Export] Use github remote, not origin

BUG=693651
Review-Url: https://codereview.chromium.org/2703663005
Cr-Commit-Position: refs/heads/master@{#451435}
Committed: https://chromium.googlesource.com/chromium/src/+/0ae0fc0d329ac9dea0ca7316eb6515dd817f0166

[jeffcarp, 2017-02-17 19:09:54]

jeffcarp@chromium.org changed reviewers:
+ qyearsley@chromium.org

[qyearsley, 2017-02-17 19:18:42]

lgtm

https://codereview.chromium.org/2703663005/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py (right):

https://codereview.chromium.org/2703663005/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py:40:
_log.info('Cloning %s into %s', WPT_REPO_URL, self.path)
Question: Would it make sense to change this to use
github.com/w3c/web-platform-tests instead of WPT_REPO_URL here?

[qyearsley, 2017-02-17 19:18:54]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 19:19:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jeffcarp, 2017-02-17 20:26:42]

On 2017/02/17 at 19:18:42, qyearsley wrote:
> lgtm
> 
>
https://codereview.chromium.org/2703663005/diff/1/third_party/WebKit/Tools/Sc...
> File third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py (right):
> 
>
https://codereview.chromium.org/2703663005/diff/1/third_party/WebKit/Tools/Sc...
> third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py:40:
_log.info('Cloning %s into %s', WPT_REPO_URL, self.path)
> Question: Would it make sense to change this to use
github.com/w3c/web-platform-tests instead of WPT_REPO_URL here?

Based on your suggestion I overhauled the way LocalWPT treats git remotes. Lmk
if you have any feedback!

[qyearsley, 2017-02-17 21:50:45]

On 2017/02/17 at 20:26:42, jeffcarp wrote:
> On 2017/02/17 at 19:18:42, qyearsley wrote:
> > lgtm
> > 
> >
https://codereview.chromium.org/2703663005/diff/1/third_party/WebKit/Tools/Sc...
> > File third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py (right):
> > 
> >
https://codereview.chromium.org/2703663005/diff/1/third_party/WebKit/Tools/Sc...
> > third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py:40:
_log.info('Cloning %s into %s', WPT_REPO_URL, self.path)
> > Question: Would it make sense to change this to use
github.com/w3c/web-platform-tests instead of WPT_REPO_URL here?
> 
> Based on your suggestion I overhauled the way LocalWPT treats git remotes. Lmk
if you have any feedback!

I think this is better, because it's simpler (only one remote). Still LGTM

One thing to think about is that this means that when wpt-import checks for
exportable commits, it will also check out only the GitHub repo. Do you know if
there's an allowable number of `git clone` requests per repo per day, or
something like that? If it turns out to be an issue, then the LocalWPT
constructor can be changed to take the repo URL as an argument.

[jeffcarp, 2017-02-18 01:22:03]

The CQ bit was checked by jeffcarp@chromium.org

[jeffcarp, 2017-02-18 01:23:11]

On 2017/02/17 at 21:50:45, qyearsley wrote:
> On 2017/02/17 at 20:26:42, jeffcarp wrote:
> > On 2017/02/17 at 19:18:42, qyearsley wrote:
> > > lgtm
> > > 
> > >
https://codereview.chromium.org/2703663005/diff/1/third_party/WebKit/Tools/Sc...
> > > File third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py (right):
> > > 
> > >
https://codereview.chromium.org/2703663005/diff/1/third_party/WebKit/Tools/Sc...
> > > third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py:40:
_log.info('Cloning %s into %s', WPT_REPO_URL, self.path)
> > > Question: Would it make sense to change this to use
github.com/w3c/web-platform-tests instead of WPT_REPO_URL here?
> > 
> > Based on your suggestion I overhauled the way LocalWPT treats git remotes.
Lmk if you have any feedback!
> 
> I think this is better, because it's simpler (only one remote). Still LGTM
> 
> One thing to think about is that this means that when wpt-import checks for
exportable commits, it will also check out only the GitHub repo. Do you know if
there's an allowable number of `git clone` requests per repo per day, or
something like that? If it turns out to be an issue, then the LocalWPT
constructor can be changed to take the repo URL as an argument.

Given the current rate of import/export I don't think we'll run into issues. I
couldn't find anything on rate limits for cloning. But as you said, if we do we
can modify LocalWPT.

[commit-bot: I haz the power, 2017-02-18 01:23:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 03:25:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 03:25:31]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[jeffcarp, 2017-02-18 06:47:19]

The CQ bit was checked by jeffcarp@chromium.org

[commit-bot: I haz the power, 2017-02-18 06:47:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 06:59:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487400439046020,
"parent_rev": "bc82717e957aeaf5b865d4f4b4c3ec7ad48360c0", "commit_rev":
"0ae0fc0d329ac9dea0ca7316eb6515dd817f0166"}

[commit-bot: I haz the power, 2017-02-18 06:59:31]

Description was changed from

==========
[WPT Export] Use github remote, not origin

BUG=693651
==========

to

==========
[WPT Export] Use github remote, not origin

BUG=693651

Review-Url: https://codereview.chromium.org/2703663005
Cr-Commit-Position: refs/heads/master@{#451435}
Committed:
https://chromium.googlesource.com/chromium/src/+/0ae0fc0d329ac9dea0ca7316eb65...
==========

[commit-bot: I haz the power, 2017-02-18 06:59:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0ae0fc0d329ac9dea0ca7316eb65...