Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1261)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py

Issue 2703663005: [WPT Export] Use github remote, not origin (Closed)
Patch Set: Simplify to only rely on origin, remove git remote check Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py
index e8c8fd2cb19e49a23f23f23c8d9da7bee9316357..dbb0aab0c5500245ca4a0288136ac5eee38f86d0 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py
@@ -22,10 +22,8 @@ class LocalWPTTest(unittest.TestCase):
local_wpt.fetch()
self.assertEqual(host.executive.calls, [
- ['git', 'fetch', '--all'],
+ ['git', 'fetch', 'origin'],
['git', 'checkout', 'origin/master'],
- ['git', 'remote'],
- ['git', 'remote', 'add', 'github', 'git@github.com:w3c/web-platform-tests.git']
])
def test_fetch_when_wpt_dir_does_not_exist(self):
@@ -35,8 +33,9 @@ class LocalWPTTest(unittest.TestCase):
local_wpt = LocalWPT(host)
local_wpt.fetch()
- self.assertEqual(len(host.executive.calls), 3)
- self.assertEqual(host.executive.calls[0][1], 'clone')
+ self.assertEqual(host.executive.calls, [
+ ['git', 'clone', 'git@github.com:w3c/web-platform-tests.git', '/tmp/wpt'],
+ ])
def test_constructor(self):
host = MockHost()
@@ -84,9 +83,7 @@ class LocalWPTTest(unittest.TestCase):
local_branch_name = local_wpt.create_branch_with_patch('message', 'patch', 'author')
self.assertEqual(local_branch_name, 'chromium-export-try')
self.assertEqual(host.executive.calls, [
- ['git', 'clone', 'https://chromium.googlesource.com/external/w3c/web-platform-tests.git', '/tmp/wpt'],
- ['git', 'remote'],
- ['git', 'remote', 'add', 'github', 'git@github.com:w3c/web-platform-tests.git'],
+ ['git', 'clone', 'git@github.com:w3c/web-platform-tests.git', '/tmp/wpt'],
['git', 'reset', '--hard', 'HEAD'],
['git', 'clean', '-fdx'],
['git', 'checkout', 'origin/master'],
@@ -96,4 +93,4 @@ class LocalWPTTest(unittest.TestCase):
['git', 'apply', '-'],
['git', 'add', '.'],
['git', 'commit', '--author', 'author', '-am', 'message'],
- ['git', 'push', '-f', 'github', 'chromium-export-try']])
+ ['git', 'push', '-f', 'origin', 'chromium-export-try']])
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698