Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2703643002:
CrOS: Rename 'cellular' to 'mobile' in UI descriptions. (Closed)
DescriptionCrOS: Rename 'cellular' to 'mobile' in UI descriptions.
Cellular connectivity and network are referred as 'Mobile Data' and
'Mobile Network' in other parts of the UI.
BUG=692792
TEST=Manually examine the affected notification and help message.
Review-Url: https://codereview.chromium.org/2703643002
Cr-Commit-Position: refs/heads/master@{#451098}
Committed: https://chromium.googlesource.com/chromium/src/+/d72f441cac1ab72578169d1647607f05d15c5ce2
Patch Set 1 #
Total comments: 3
Messages
Total messages: 15 (5 generated)
Description was changed from ========== CrOS: Rename 'cellular' to 'mobile' in UI descriptions. Cellular connectivity and network are referred as 'Mobile Data' and 'Mobile Network' in other parts of the UI. BUG=692792 TEST=Manually examine the affected notification and help message. ========== to ========== CrOS: Rename 'cellular' to 'mobile' in UI descriptions. Cellular connectivity and network are referred as 'Mobile Data' and 'Mobile Network' in other parts of the UI. BUG=692792 TEST=Manually examine the affected notification and help message. ==========
benchan@chromium.org changed reviewers: + stevenjb@chromium.org
https://codereview.chromium.org/2703643002/diff/1/chrome/app/chromeos_strings... File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/2703643002/diff/1/chrome/app/chromeos_strings... chrome/app/chromeos_strings.grdp:3969: Mobile I just pinged tbuckley@ about this, is it 'Mobile' or 'Mobile network' here, do you know for sure?
https://codereview.chromium.org/2703643002/diff/1/chrome/app/chromeos_strings... File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/2703643002/diff/1/chrome/app/chromeos_strings... chrome/app/chromeos_strings.grdp:3969: Mobile On 2017/02/16 18:45:10, stevenjb wrote: > I just pinged tbuckley@ about this, is it 'Mobile' or 'Mobile network' here, do > you know for sure? My understanding is that this piece of string is used to replace the placeholder of the IDS_UPGRADE_DISALLOWED message, which already has 'network' at the end. You are currently connected to the <ph name="NETWORK_TYPE">$1<ex>mobile</ex></ph> network.
On 2017/02/16 18:51:26, Ben Chan wrote: > https://codereview.chromium.org/2703643002/diff/1/chrome/app/chromeos_strings... > File chrome/app/chromeos_strings.grdp (right): > > https://codereview.chromium.org/2703643002/diff/1/chrome/app/chromeos_strings... > chrome/app/chromeos_strings.grdp:3969: Mobile > On 2017/02/16 18:45:10, stevenjb wrote: > > I just pinged tbuckley@ about this, is it 'Mobile' or 'Mobile network' here, > do > > you know for sure? > > My understanding is that this piece of string is used to replace the placeholder > of the IDS_UPGRADE_DISALLOWED message, which already has 'network' at the end. > > You are currently connected to the <ph > name="NETWORK_TYPE">$1<ex>mobile</ex></ph> network. The other place using this string is ui/webui/resources/cr_elements/network/cr_onc_types.js. Do you know how to trigger this view?
On 2017/02/16 18:53:12, Ben Chan wrote: > On 2017/02/16 18:51:26, Ben Chan wrote: > > > https://codereview.chromium.org/2703643002/diff/1/chrome/app/chromeos_strings... > > File chrome/app/chromeos_strings.grdp (right): > > > > > https://codereview.chromium.org/2703643002/diff/1/chrome/app/chromeos_strings... > > chrome/app/chromeos_strings.grdp:3969: Mobile > > On 2017/02/16 18:45:10, stevenjb wrote: > > > I just pinged tbuckley@ about this, is it 'Mobile' or 'Mobile network' here, > > do > > > you know for sure? > > > > My understanding is that this piece of string is used to replace the > placeholder > > of the IDS_UPGRADE_DISALLOWED message, which already has 'network' at the end. > > > > You are currently connected to the <ph > > name="NETWORK_TYPE">$1<ex>mobile</ex></ph> network. > > The other place using this string is > ui/webui/resources/cr_elements/network/cr_onc_types.js. > Do you know how to trigger this view? Yeah, that is used in any WebUI where we show networks (oobe and Settings). If we decide to change that to, e.g., "Mobile network", I will add a separate string for that. lgtm
https://codereview.chromium.org/2703643002/diff/1/chrome/app/chromeos_strings... File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/2703643002/diff/1/chrome/app/chromeos_strings... chrome/app/chromeos_strings.grdp:3969: Mobile On 2017/02/16 18:51:23, Ben Chan wrote: > On 2017/02/16 18:45:10, stevenjb wrote: > > I just pinged tbuckley@ about this, is it 'Mobile' or 'Mobile network' here, > do > > you know for sure? > > My understanding is that this piece of string is used to replace the placeholder > of the IDS_UPGRADE_DISALLOWED message, which already has 'network' at the end. > > You are currently connected to the <ph > name="NETWORK_TYPE">$1<ex>mobile</ex></ph> network. OK, yeah, it makes sense to just make this "Mobile". If we need to change it where we use the term by itself in Settings, we can create a new string for that.
The CQ bit was checked by benchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487276614425180, "parent_rev":
"f39789610ff9561637d89668a0b8e62c58b3f1f2", "commit_rev":
"d72f441cac1ab72578169d1647607f05d15c5ce2"}
Message was sent while issue was closed.
Description was changed from ========== CrOS: Rename 'cellular' to 'mobile' in UI descriptions. Cellular connectivity and network are referred as 'Mobile Data' and 'Mobile Network' in other parts of the UI. BUG=692792 TEST=Manually examine the affected notification and help message. ========== to ========== CrOS: Rename 'cellular' to 'mobile' in UI descriptions. Cellular connectivity and network are referred as 'Mobile Data' and 'Mobile Network' in other parts of the UI. BUG=692792 TEST=Manually examine the affected notification and help message. Review-Url: https://codereview.chromium.org/2703643002 Cr-Commit-Position: refs/heads/master@{#451098} Committed: https://chromium.googlesource.com/chromium/src/+/d72f441cac1ab72578169d164760... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d72f441cac1ab72578169d164760... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
