Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2703393004:
Remove DumpWithoutCrashing() from extension_prefs (Closed)
|
Created:
3 years, 10 months ago by scottmg Modified:
3 years, 10 months ago CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, lcwu+watch_chromium.org, alokp+watch_chromium.org, halliwell+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove DumpWithoutCrashing() from extension_prefs
Bug appears to have been resolved, trying rationalize all calls to
DumpWithoutCrashing() and remove any unnecessary ones.
R=rdevlin.cronin@chromium.org
BUG=616149, 694688
Review-Url: https://codereview.chromium.org/2703393004
Cr-Commit-Position: refs/heads/master@{#452069}
Committed: https://chromium.googlesource.com/chromium/src/+/8d2142efacf01639e95d5d26b789f846ac62c0ad
Patch Set 1 #
Messages
Total messages: 33 (17 generated)
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm, but I think the linked bug should be 616149 instead of 616419
Description was changed from ========== Remove DumpWithoutCrashing() from extension_prefs Bug appears to have been resolved, trying rationalize all calls to DumpWithoutCrashing() and remove any unnecessary ones. R=rdevlin.cronin@chromium.org BUG=616419,694688 ========== to ========== Remove DumpWithoutCrashing() from extension_prefs Bug appears to have been resolved, trying rationalize all calls to DumpWithoutCrashing() and remove any unnecessary ones. R=rdevlin.cronin@chromium.org BUG=616149 ,694688 ==========
On 2017/02/21 21:13:59, Devlin wrote: > lgtm, but I think the linked bug should be 616149 instead of 616419 Oops, thanks, done.
The CQ bit was unchecked by scottmg@chromium.org
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
scottmg@chromium.org changed reviewers: + rsesek@chromium.org
scottmg@chromium.org changed reviewers: + slan@chromium.org
+rsesek for chrome/common/crash_keys.cc +slan for chromecast/crash/cast_crash_keys.cc
lgtm
cast lgtm
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487777775753970, "parent_rev":
"e4dd371c464f77b6fbef56d212f7de71e03bf002", "commit_rev":
"8d2142efacf01639e95d5d26b789f846ac62c0ad"}
Message was sent while issue was closed.
Description was changed from ========== Remove DumpWithoutCrashing() from extension_prefs Bug appears to have been resolved, trying rationalize all calls to DumpWithoutCrashing() and remove any unnecessary ones. R=rdevlin.cronin@chromium.org BUG=616149 ,694688 ========== to ========== Remove DumpWithoutCrashing() from extension_prefs Bug appears to have been resolved, trying rationalize all calls to DumpWithoutCrashing() and remove any unnecessary ones. R=rdevlin.cronin@chromium.org BUG=616149 ,694688 Review-Url: https://codereview.chromium.org/2703393004 Cr-Commit-Position: refs/heads/master@{#452069} Committed: https://chromium.googlesource.com/chromium/src/+/8d2142efacf01639e95d5d26b789... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/8d2142efacf01639e95d5d26b789... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
