Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: extensions/browser/extension_prefs.cc

Issue 2703393004: Remove DumpWithoutCrashing() from extension_prefs (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/crash/cast_crash_keys.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/extension_prefs.cc
diff --git a/extensions/browser/extension_prefs.cc b/extensions/browser/extension_prefs.cc
index a3ade026ba36ea548bc0fb61619934e47309cc24..77124a8f9cf878e723e89c727bd553d1322e661a 100644
--- a/extensions/browser/extension_prefs.cc
+++ b/extensions/browser/extension_prefs.cc
@@ -10,8 +10,6 @@
#include <iterator>
#include <utility>
-#include "base/debug/crash_logging.h"
-#include "base/debug/dump_without_crashing.h"
#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "base/metrics/histogram_macros.h"
@@ -317,10 +315,6 @@ T* ExtensionPrefs::ScopedUpdate<T, type_enum_value>::Create() {
// might be useful. Remove the dumps after we analyze them.
if (key_value->GetType() != type_enum_value) {
NOTREACHED();
- base::debug::SetCrashKeyValue(
- "existing_extension_pref_value_type",
- base::IntToString(static_cast<int>(key_value->GetType())));
- base::debug::DumpWithoutCrashing();
value_as_t = new T();
extension->SetWithoutPathExpansion(key_, base::WrapUnique(value_as_t));
} else {
« no previous file with comments | « chromecast/crash/cast_crash_keys.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698