Web Share: Refactor Mojo interface to now return an enum error.

chrome/browser/webshare/share_service_impl_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 16 matching lines @@
 
 constexpr char kTargetName[] = "Share Target";
 constexpr char kUrlTemplate[] = "share?title={title}&text={text}&url={url}";
 constexpr char kManifestUrlHigh[] =
     "https://www.example-high.com/target/manifest.json";
 constexpr char kManifestUrlLow[] =
     "https://www.example-low.com/target/manifest.json";
 constexpr char kManifestUrlMin[] =
     "https://www.example-min.com/target/manifest.json";
 
-void DidShare(const base::Optional<std::string>& expected_error,
-              const base::Optional<std::string>& error) {
+void DidShare(blink::mojom::ShareError expected_error,
+              blink::mojom::ShareError error) {
   EXPECT_EQ(expected_error, error);
 }
 
 class ShareServiceTestImpl : public ShareServiceImpl {
  public:
   explicit ShareServiceTestImpl(blink::mojom::ShareServiceRequest request)
       : binding_(this) {
     binding_.Bind(std::move(request));
 
     pref_service_.reset(new TestingPrefServiceSimple());
@@ skipping 119 matching lines @@
 }  // namespace
 
 // Basic test to check the Share method calls the callback with the expected
 // parameters.
 TEST_F(ShareServiceImplUnittest, ShareCallbackParams) {
   share_service_helper()->AddShareTargetToPrefs(kManifestUrlLow, kTargetName,
                                                 kUrlTemplate);
   share_service_helper()->AddShareTargetToPrefs(kManifestUrlHigh, kTargetName,
                                                 kUrlTemplate);
 
-  base::Callback<void(const base::Optional<std::string>&)> callback =
-      base::Bind(&DidShare, base::Optional<std::string>());
+  base::Callback<void(blink::mojom::ShareError)> callback =
+      base::Bind(&DidShare, blink::mojom::ShareError::OK);
 
   base::RunLoop run_loop;
   share_service_helper()->set_run_loop(&run_loop);
 
   const GURL url(kUrlSpec);
   share_service()->Share(kTitle, kText, url, callback);
 
   run_loop.Run();
 
   const std::vector<std::pair<base::string16, GURL>> kExpectedTargets{
       make_pair(base::UTF8ToUTF16(kTargetName), GURL(kManifestUrlHigh)),
       make_pair(base::UTF8ToUTF16(kTargetName), GURL(kManifestUrlLow))};
   EXPECT_EQ(kExpectedTargets, share_service_helper()->GetTargetsInPicker());
 
   // Pick example-low.com.
   share_service_helper()->picker_callback().Run(
       base::Optional<std::string>(kManifestUrlLow));
 
   const char kExpectedURL[] =
       "https://www.example-low.com/target/"
       "share?title=My%20title&text=My%20text&url=https%3A%2F%2Fwww."
       "google.com%2F";
   EXPECT_EQ(kExpectedURL, share_service_helper()->GetLastUsedTargetURL());
 }
 
 // Tests the result of cancelling the share in the picker UI, that doesn't have
 // any targets.
 TEST_F(ShareServiceImplUnittest, ShareCancelNoTargets) {
   // Expect an error message in response.
-  base::Callback<void(const base::Optional<std::string>&)> callback =
-      base::Bind(&DidShare, base::Optional<std::string>("Share was cancelled"));
+  base::Callback<void(blink::mojom::ShareError)> callback =
+      base::Bind(&DidShare, blink::mojom::ShareError::CANCELED);
 
   base::RunLoop run_loop;
   share_service_helper()->set_run_loop(&run_loop);
 
   const GURL url(kUrlSpec);
   share_service()->Share(kTitle, kText, url, callback);
 
   run_loop.Run();
 
   EXPECT_TRUE(share_service_helper()->GetTargetsInPicker().empty());
 
   // Cancel the dialog.
   share_service_helper()->picker_callback().Run(base::nullopt);
 
   EXPECT_TRUE(share_service_helper()->GetLastUsedTargetURL().empty());
 }
 
 // Tests the result of cancelling the share in the picker UI, that has targets.
 TEST_F(ShareServiceImplUnittest, ShareCancelWithTargets) {
   share_service_helper()->AddShareTargetToPrefs(kManifestUrlHigh, kTargetName,
                                                 kUrlTemplate);
   share_service_helper()->AddShareTargetToPrefs(kManifestUrlLow, kTargetName,
                                                 kUrlTemplate);
 
   // Expect an error message in response.
-  base::Callback<void(const base::Optional<std::string>&)> callback =
-      base::Bind(&DidShare, base::Optional<std::string>("Share was cancelled"));
+  base::Callback<void(blink::mojom::ShareError)> callback =
+      base::Bind(&DidShare, blink::mojom::ShareError::CANCELED);
 
   base::RunLoop run_loop;
   share_service_helper()->set_run_loop(&run_loop);
 
   const GURL url(kUrlSpec);
   share_service()->Share(kTitle, kText, url, callback);
 
   run_loop.Run();
 
   const std::vector<std::pair<base::string16, GURL>> kExpectedTargets{
       make_pair(base::UTF8ToUTF16(kTargetName), GURL(kManifestUrlHigh)),
       make_pair(base::UTF8ToUTF16(kTargetName), GURL(kManifestUrlLow))};
   EXPECT_EQ(kExpectedTargets, share_service_helper()->GetTargetsInPicker());
 
   // Cancel the dialog.
   share_service_helper()->picker_callback().Run(base::nullopt);
 
   EXPECT_TRUE(share_service_helper()->GetLastUsedTargetURL().empty());
 }
 
 // Tests a target with a broken URL template (ReplacePlaceholders failure).
 TEST_F(ShareServiceImplUnittest, ShareBrokenUrl) {
   // Invalid placeholders. Detailed tests for broken templates are in the
   // ReplacePlaceholders test; this just tests the share response.
   constexpr char kBrokenUrlTemplate[] = "share?title={title";
   share_service_helper()->AddShareTargetToPrefs(kManifestUrlHigh, kTargetName,
                                                 kBrokenUrlTemplate);
 
   // Expect an error message in response.
-  base::Callback<void(const base::Optional<std::string>&)> callback =
-      base::Bind(&DidShare,
-                 base::Optional<std::string>(
-                     "Error: unable to replace placeholders in url template"));
+  base::Callback<void(blink::mojom::ShareError)> callback =
+      base::Bind(&DidShare, blink::mojom::ShareError::INTERNAL_ERROR);
 
   base::RunLoop run_loop;
   share_service_helper()->set_run_loop(&run_loop);
 
   const GURL url(kUrlSpec);
   share_service()->Share(kTitle, kText, url, callback);
 
   run_loop.Run();
 
   const std::vector<std::pair<base::string16, GURL>> kExpectedTargets{
       make_pair(base::UTF8ToUTF16(kTargetName), GURL(kManifestUrlHigh))};
   EXPECT_EQ(kExpectedTargets, share_service_helper()->GetTargetsInPicker());
 
   // Pick example-high.com.
   share_service_helper()->picker_callback().Run(
       base::Optional<std::string>(kManifestUrlHigh));
 
   EXPECT_TRUE(share_service_helper()->GetLastUsedTargetURL().empty());
 }
 
 // Test to check that only targets with enough engagement were in picker.
 TEST_F(ShareServiceImplUnittest, ShareWithSomeInsufficientlyEngagedTargets) {
   share_service_helper()->AddShareTargetToPrefs(kManifestUrlMin, kTargetName,
                                                 kUrlTemplate);
   share_service_helper()->AddShareTargetToPrefs(kManifestUrlLow, kTargetName,
                                                 kUrlTemplate);
 
-  base::Callback<void(const base::Optional<std::string>&)> callback =
-      base::Bind(&DidShare, base::Optional<std::string>());
+  base::Callback<void(blink::mojom::ShareError)> callback =
+      base::Bind(&DidShare, blink::mojom::ShareError::OK);
 
   base::RunLoop run_loop;
   share_service_helper()->set_run_loop(&run_loop);
 
   const GURL url(kUrlSpec);
   share_service()->Share(kTitle, kText, url, callback);
 
   run_loop.Run();
 
   const std::vector<std::pair<base::string16, GURL>> kExpectedTargets{
@@ skipping 18 matching lines @@
                                                 kUrlTemplate);
 
   base::RunLoop run_loop;
   share_service_helper()->set_run_loop(&run_loop);
 
   const GURL url(kUrlSpec);
   // Expect the callback to never be called (since the share service is
   // destroyed before the picker is closed).
   // TODO(mgiuca): This probably should still complete the share, if not
   // cancelled, even if the underlying tab is closed.
-  base::Callback<void(const base::Optional<std::string>&)> callback =
-      base::Bind([](const base::Optional<std::string>& error) { FAIL(); });
+  base::Callback<void(blink::mojom::ShareError)> callback =
+      base::Bind([](blink::mojom::ShareError error) { FAIL(); });
   share_service()->Share(kTitle, kText, url, callback);
 
   run_loop.Run();
 
   const std::vector<std::pair<base::string16, GURL>> kExpectedTargets{
       make_pair(base::UTF8ToUTF16(kTargetName), GURL(kManifestUrlLow))};
   EXPECT_EQ(kExpectedTargets, share_service_helper()->GetTargetsInPicker());
 
   const base::Callback<void(base::Optional<std::string>)> picker_callback =
       share_service_helper()->picker_callback();
@@ skipping 200 matching lines @@
   EXPECT_TRUE(succeeded);
   EXPECT_EQ("%C3%A9", url_template_filled);
 
   // U+1F4A9
   url_template = "{title}";
   succeeded = ShareServiceImpl::ReplacePlaceholders(
       url_template, "\xf0\x9f\x92\xa9", kText, url, &url_template_filled);
   EXPECT_TRUE(succeeded);
   EXPECT_EQ("%F0%9F%92%A9", url_template_filled);
 }