Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2703283002: Revert of MD Settings: enable by default in client (Closed)

Created:
3 years, 10 months ago by kinaba
Modified:
3 years, 10 months ago
Reviewers:
dpapad, Dan Beam, sky
CC:
chromium-reviews, groby-ooo-7-16
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of MD Settings: enable by default in client (patchset #4 id:60001 of https://codereview.chromium.org/2699973002/ ) Reason for revert: BUG=694081 It broke ChromeOS tests and thus blocked Chrome roll to ChromeOS. In my personal opinion, what really needs fix are the tests rather than the change, but the changes to the tests looks far nontrivial. For now, allow me to revert this change to unblock the divergence between Chrome and ChromeOS ToT... Original issue's description: > MD Settings: enable by default in client > > R=dpapad@chromium.org > BUG=478982 > > Review-Url: https://codereview.chromium.org/2699973002 > Cr-Commit-Position: refs/heads/master@{#451338} > Committed: https://chromium.googlesource.com/chromium/src/+/a8109d958f144e541a204da6debd820d936d6108 TBR=dpapad@chromium.org,sky@chromium.org,dbeam@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=478982 Review-Url: https://codereview.chromium.org/2703283002 Cr-Commit-Position: refs/heads/master@{#451684} Committed: https://chromium.googlesource.com/chromium/src/+/d7d491d6a26d61a06f96d8e924c54902e5c52ed4

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
kinaba
Created Revert of MD Settings: enable by default in client
3 years, 10 months ago (2017-02-21 01:00:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703283002/1
3 years, 10 months ago (2017-02-21 01:00:50 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 01:49:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d7d491d6a26d61a06f96d8e924c5...

Powered by Google App Engine
This is Rietveld 408576698