MD Settings: enable by default in client

MD Settings: enable by default in client

R=dpapad@chromium.org, sky@chromium.org
BUG=478982
Review-Url: https://codereview.chromium.org/2699973002
Cr-Original-Commit-Position: refs/heads/master@{#451338}
Committed: https://chromium.googlesource.com/chromium/src/+/a8109d958f144e541a204da6debd820d936d6108
Review-Url: https://codereview.chromium.org/2699973002 .
Cr-Commit-Position: refs/heads/master@{#451882}
Committed: https://chromium.googlesource.com/chromium/src/+/b9135d31f35a07fb2677c8c7266ddf9ed27f784e

[Dan Beam, 2017-02-16 20:09:48]

if we don't make 58, we'll revert this on the branch

[Dan Beam, 2017-02-16 20:10:02]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[groby-ooo-7-16, 2017-02-16 20:11:07]

On 2017/02/16 20:09:48, Dan Beam wrote:
> if we don't make 58, we'll revert this on the branch

Looks incredibly awesome from over here ;)

[commit-bot: I haz the power, 2017-02-16 20:11:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-02-16 20:24:14]

lgtm

[commit-bot: I haz the power, 2017-02-16 21:04:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 21:04:28]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Dan Beam, 2017-02-17 01:46:05]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 01:48:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-02-17 01:57:14]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 01:58:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-02-17 02:09:06]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 02:09:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-02-17 03:22:17]

dbeam@chromium.org changed reviewers:
+ sky@chromium.org

[Dan Beam, 2017-02-17 03:22:19]

sorry sky@, one more for you!

can you stamp

  chrome/browser/browser_about_handler_unittest.cc
 
chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
  chrome/browser/policy/policy_browsertest.cc

for me?

  chrome/browser/chrome_content_browser_client_browsertest.cc

is OWNERS=*, so you don't need to look at that one (unless you want, go nuts).

I'm just disabling Material Design settings in tests that assume the old options
page (and wouldn't really be high value once it ships), and updating ones that
should live in the future to check whether the feature is enabled.

https://codereview.chromium.org/2699973002/diff/60001/chrome/browser/browser_...
File chrome/browser/browser_about_handler_unittest.cc (right):

https://codereview.chromium.org/2699973002/diff/60001/chrome/browser/browser_...
chrome/browser/browser_about_handler_unittest.cc:121:
TEST_F(BrowserAboutHandlerTest, WillHandleBrowserAboutURLForMDSettings) {
has an MD version

https://codereview.chromium.org/2699973002/diff/60001/chrome/browser/chrome_c...
File chrome/browser/chrome_content_browser_client_browsertest.cc (right):

https://codereview.chromium.org/2699973002/diff/60001/chrome/browser/chrome_c...
chrome/browser/chrome_content_browser_client_browsertest.cc:76: }
chrome://chrome will not be used any more for settings when Material Design
version ships (it's not in the "uber" page in an iframe, but in a standalone
page)

https://codereview.chromium.org/2699973002/diff/60001/chrome/browser/policy/p...
File chrome/browser/policy/policy_browsertest.cc (right):

https://codereview.chromium.org/2699973002/diff/60001/chrome/browser/policy/p...
chrome/browser/policy/policy_browsertest.cc:4326:
"document.getElementById('resolve-timezone-by-geolocation');\n"
this is very specific to the old options page and would need to be changed a bit
or removed when we move to md-settings

[commit-bot: I haz the power, 2017-02-17 04:14:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 04:14:24]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[sky, 2017-02-17 17:14:30]

said files LGTM

[Dan Beam, 2017-02-17 18:02:07]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-02-17 18:02:08]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2699973002/#ps60001
(title: "test fixes?")

[commit-bot: I haz the power, 2017-02-17 18:02:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 18:11:07]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487354527491610,
"parent_rev": "e85944f082b27f903fcea5491549de058e157528", "commit_rev":
"a8109d958f144e541a204da6debd820d936d6108"}

[commit-bot: I haz the power, 2017-02-17 18:11:45]

Description was changed from

==========
MD Settings: enable by default in client

R=dpapad@chromium.org
BUG=478982
==========

to

==========
MD Settings: enable by default in client

R=dpapad@chromium.org
BUG=478982

Review-Url: https://codereview.chromium.org/2699973002
Cr-Commit-Position: refs/heads/master@{#451338}
Committed:
https://chromium.googlesource.com/chromium/src/+/a8109d958f144e541a204da6debd...
==========

[commit-bot: I haz the power, 2017-02-17 18:11:46]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a8109d958f144e541a204da6debd...

[kinaba, 2017-02-21 01:00:37]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2703283002/ by kinaba@chromium.org.

The reason for reverting is: BUG=694081

It broke ChromeOS tests and thus blocked Chrome roll to ChromeOS.
In my personal opinion, what really needs fix are the tests rather than the
change,
but the changes to the tests looks far nontrivial.
For now, allow me to revert this change to unblock the divergence between Chrome
and ChromeOS ToT....

[Dan Beam, 2017-02-21 18:45:58]

Description was changed from

==========
MD Settings: enable by default in client

R=dpapad@chromium.org
BUG=478982

Review-Url: https://codereview.chromium.org/2699973002
Cr-Commit-Position: refs/heads/master@{#451338}
Committed:
https://chromium.googlesource.com/chromium/src/+/a8109d958f144e541a204da6debd...
==========

to

==========
MD Settings: enable by default in client

R=dpapad@chromium.org
BUG=478982

Review-Url: https://codereview.chromium.org/2699973002
Cr-Commit-Position: refs/heads/master@{#451338}
Committed:
https://chromium.googlesource.com/chromium/src/+/a8109d958f144e541a204da6debd...
==========

[Dan Beam, 2017-02-21 19:17:38]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[Dan Beam, 2017-02-21 19:18:00]

re-enabling everywhere but cros

[commit-bot: I haz the power, 2017-02-21 19:18:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 21:22:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 21:22:23]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Dan Beam, 2017-02-21 22:41:14]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-02-21 22:41:14]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2699973002/#ps80001
(title: "disable cros")

[commit-bot: I haz the power, 2017-02-21 22:43:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 00:47:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 00:47:23]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[Dan Beam, 2017-02-22 00:57:39]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-02-22 00:59:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 03:04:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 03:04:53]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[Dan Beam, 2017-02-22 03:17:44]

Description was changed from

==========
MD Settings: enable by default in client

R=dpapad@chromium.org
BUG=478982

Review-Url: https://codereview.chromium.org/2699973002
Cr-Commit-Position: refs/heads/master@{#451338}
Committed:
https://chromium.googlesource.com/chromium/src/+/a8109d958f144e541a204da6debd...
==========

to

==========
MD Settings: enable by default in client

R=dpapad@chromium.org, sky@chromium.org
BUG=478982

Review-Url: https://codereview.chromium.org/2699973002
Cr-Original-Commit-Position: refs/heads/master@{#451338}
Committed:
https://chromium.googlesource.com/chromium/src/+/a8109d958f144e541a204da6debd...
Review-Url: https://codereview.chromium.org/2699973002 .
Cr-Commit-Position: refs/heads/master@{#451882}
Committed:
https://chromium.googlesource.com/chromium/src/+/b9135d31f35a07fb2677c8c7266d...
==========

[Dan Beam, 2017-02-22 03:17:46]

Committed patchset #5 (id:80001) manually as
b9135d31f35a07fb2677c8c7266ddf9ed27f784e (presubmit successful).