Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2703253003: WASAPIAudioInputStream: Revert to the previous buffer size calculation. (Closed)

Created:
3 years, 10 months ago by tommi (sloooow) - chröme
Modified:
3 years, 10 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WASAPIAudioInputStream: Revert to the previous buffer size calculation. This reverts part of a change landed last week for the case when no audio conversion is needed in WASAPIAudioInputStream. The reason for reverting is that a part of the WASAPIAudioInputStreamTestPacketSizes test started failing, the part that uses 5ms buffer sizes. For the case when conversion is needed and we have an imperfect buffer size ratio, we add one more buffer as before. BUG=694284 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2703253003 Cr-Commit-Position: refs/heads/master@{#451665} Committed: https://chromium.googlesource.com/chromium/src/+/c6e9b13174cd446b65b679bdfca1c8a8dc25ac1c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M media/audio/win/audio_low_latency_input_win.cc View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tommi (sloooow) - chröme
3 years, 10 months ago (2017-02-20 19:37:30 UTC) #3
DaleCurtis
lgtm
3 years, 10 months ago (2017-02-20 21:25:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703253003/1
3 years, 10 months ago (2017-02-20 22:31:01 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 22:35:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c6e9b13174cd446b65b679bdfca1...

Powered by Google App Engine
This is Rietveld 408576698