Migrate extension notifications to the new NotificationDisplayService

chrome/browser/notifications/notification_common.h

Index: chrome/browser/notifications/notification_common.h
diff --git a/chrome/browser/notifications/notification_common.h b/chrome/browser/notifications/notification_common.h
index 280c84df461e0fe43a28fa0c4751d4f758392a2b..9bf8d48a364e1c968c40b655abe8785ef19071d1 100644
--- a/chrome/browser/notifications/notification_common.h
+++ b/chrome/browser/notifications/notification_common.h
@@ -13,6 +13,7 @@ class BrowserContext;
 class NotificationCommon {
  public:
   // Things as user can do to a notification.
+  // TODO(peter): Prefix these options with OPERATION_.

[Miguel Garcia, 2017/02/21 10:56:44]

FWIW we discussed this during the initial review and decided against it since it
seemed an overkill. Happy to revisit the decision again though.

[Peter Beverloo, 2017/02/21 17:23:50]

We didn't use the prefix when we used `enum classes`, which mean callers used:

  NotificationCommon::Operation::SETTINGS

Now that we switched back to regular enums as we use them as ints, callers now
use:

  NotificationCommon::SETTINGS

That conveys no information about what "settings" is. It's not a style guide
violation, but I do think it's much clearer. WDYT?

   enum Operation {
     CLICK = 0,
     CLOSE = 1,
@@ -21,10 +22,12 @@ class NotificationCommon {
   };
 
   // Possible kinds of notifications
+  // TODO(peter): Prefix these options with TYPE_.
   enum Type {
     PERSISTENT = 0,
     NON_PERSISTENT = 1,
-    TYPE_MAX = NON_PERSISTENT
+    EXTENSION = 2,
+    TYPE_MAX = EXTENSION
   };
 
   // Open the Notification settings screen when clicking the right button.