Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Unified Diff: chrome/browser/notifications/native_notification_display_service.cc

Issue 2703213004: Migrate extension notifications to the new NotificationDisplayService (Closed)
Patch Set: Finish functionality Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/native_notification_display_service.cc
diff --git a/chrome/browser/notifications/native_notification_display_service.cc b/chrome/browser/notifications/native_notification_display_service.cc
index 2de879d0bee177fe377d7bfd028db38317b7c310..e0b3a9149cb8227c46fb132eafd3f4ed2d1ab47a 100644
--- a/chrome/browser/notifications/native_notification_display_service.cc
+++ b/chrome/browser/notifications/native_notification_display_service.cc
@@ -7,6 +7,7 @@
#include "base/memory/ptr_util.h"
#include "base/strings/nullable_string16.h"
#include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/extensions/api/notifications/extension_notification_handler.h"
Miguel Garcia 2017/02/21 10:56:44 yeah I can see how this include is not great... A
Peter Beverloo 2017/02/21 17:23:50 Sure. Fixed for now.
#include "chrome/browser/notifications/non_persistent_notification_handler.h"
#include "chrome/browser/notifications/notification.h"
#include "chrome/browser/notifications/notification_delegate.h"
@@ -40,6 +41,8 @@ NativeNotificationDisplayService::NativeNotificationDisplayService(
base::MakeUnique<NonPersistentNotificationHandler>());
AddNotificationHandler(NotificationCommon::PERSISTENT,
base::MakeUnique<PersistentNotificationHandler>());
+ AddNotificationHandler(NotificationCommon::EXTENSION,
+ base::MakeUnique<ExtensionNotificationHandler>());
}
NativeNotificationDisplayService::~NativeNotificationDisplayService() {}

Powered by Google App Engine
This is Rietveld 408576698